fix(workflows): populate doc in apply_workflow whitelisted method #21068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #21068 +/- ##
===========================================
+ Coverage 63.76% 63.95% +0.19%
===========================================
Files 764 764
Lines 69058 69049 -9
Branches 6244 6243 -1
===========================================
+ Hits 44034 44160 +126
+ Misses 21412 21342 -70
+ Partials 3612 3547 -65
Flags with carried forward coverage won't be shown. Click here to find out more. |
mergify bot
pushed a commit
that referenced
this pull request
May 24, 2023
(cherry picked from commit a182414)
phot0n
pushed a commit
that referenced
this pull request
May 24, 2023
frappe-pr-bot
pushed a commit
that referenced
this pull request
May 30, 2023
# [14.37.0](v14.36.3...v14.37.0) (2023-05-30) ### Bug Fixes * add selected on current dropdown-item ([6af79f2](6af79f2)) * added left icon option ([dd86670](dd86670)) * allow default for text and long text when altering table ([#21109](#21109)) ([#21124](#21124)) ([b8c6a7b](b8c6a7b)) * allow setting default in longtext and text columns ([#21089](#21089)) ([#21123](#21123)) ([1f477c2](1f477c2)) * clear & add email template using select group btn ([e367821](e367821)) * create private custom html block ([a552ad9](a552ad9)) * don't mutate notification when getting cc and bcc ([82515b2](82515b2)) * ensure correct return value for `get_values_from_single` ([aee1775](aee1775)) * Exclude Geolocation from "hide empty read-only field" ([#21088](#21088)) ([#21096](#21096)) ([8b76dab](8b76dab)) * made a util to create shadow element ([0427ae0](0427ae0)) * make desk css available i shadow html ([1c085a6](1c085a6)) * make dropdown item label bold ([7bda6a1](7bda6a1)) * make option toggle button smaller ([3aed586](3aed586)) * misc form tour fixes (backport [#21151](#21151)) ([#21152](#21152)) ([2411e66](2411e66)) * offset log cleanup to avoid deadlocks ([#21105](#21105)) ([#21106](#21106)) ([4ba4c94](4ba4c94)) * only show public and user's private blocks in dropdown ([cffa676](cffa676)) * removed html message since we no longer have no ristrictions ([b5a714b](b5a714b)) * setup wizard recursion in routing ([#21101](#21101)) ([#21102](#21102)) ([6c3026f](6c3026f)) * skip form tours on mobile ([#21180](#21180)) ([d87c815](d87c815)) * **workflow:** populate doc from db in apply_workflow ([#21068](#21068)) ([#21093](#21093)) ([a447488](a447488)) ### Features * Allow setting cron as Server Script frequency (backport [#21142](#21142)) ([#21161](#21161)) ([ededac7](ededac7)) * Round QB function ([9d9465a](9d9465a)) * select group button ([e9a474c](e9a474c)) * Truncate QB function ([5d24591](5d24591)) * UI onboarding tours [v14] ([#21114](#21114)) ([181f509](181f509))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
apply_workflowmethod infrappe.model.workflowconsistently fails right now. The problem is accurately described here: #11883The fix was applied to the
get_transitionsmethod, but it was never applied toapply_workflow. As a consequence, theapply_workflowmethod sends an "empty" document toget_transitions, which leaves the current workflow state undefined and throws an exception here:https://github.com/frappe/frappe/blame/c643d4a33cc58d10c0a3d81c9ed9df9bf6cc0776/frappe/model/workflow.py#L57
Asking
apply_workflowto load from the db solves this problem.