fix: set default user value only if enabled #20715
Conversation
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
|
keep alive |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
|
keep alive |
|
@surajshetty3416 can you take a look at this? |
There was a problem hiding this comment.
@vorasmit Can you share the behaviour after fix? How does it resolve the issue?
It looks like it'll still set same value if "is_default" is checked.
BeforeAfterIt will set the default value only if checked. Else it wouldn't set the default value. |
Following is the screenshot of the setting in user permission:
Existing Behaviour:
Issue:
When there is more than one Warehouse field in a doctype, it sets the default for all the fields. Most of the time, it's not supposed to be the same. eg: from_warehouse has to be different from to_warehouse.