8000 fix: Allow everyone to read geo data by ankush · Pull Request #19451 · frappe/frappe · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: Allow everyone to read geo data #19451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 2, 2023
Merged

fix: Allow everyone to read geo data #19451

merged 1 commit into from
Jan 2, 2023

Conversation

ankush
Copy link
Member
@ankush ankush commented Jan 2, 2023

This is static data present in code, no need to apply permissions.

closes #19394

This is static data present in code, no need to apply permissions.

closes #19394
@ankush ankush requested review from a team and phot0n and removed request for a team January 2, 2023 06:30
@ankush ankush added the Skip CI Doesn't run Ci for this PR. label Jan 2, 2023
@github-actions github-actions bot added the add-test-cases Add test case to validate fix or enhancement label Jan 2, 2023
@ankush ankush merged commit 5ece1d7 into develop Jan 2, 2023
@ankush ankush deleted the allow_guest_geo branch January 2, 2023 06:31
@ankush ankush added backport version-14-hotfix backport to version 14 and removed add-test-cases Add test case to validate fix or enhancement labels Jan 2, 2023
mergify bot pushed a commit that referenced this pull request Jan 2, 2023
This is static data present in code, no need to apply permissions.

closes #19394

(cherry picked from commit 5ece1d7)
ankush added a commit that referenced this pull request Jan 2, 2023
This is static data present in code, no need to apply permissions.

closes #19394

(cherry picked from commit 5ece1d7)

Co-authored-by: Ankush Menat <ankush@frappe.io>
frappe-pr-bot pushed a commit that referenced this pull request Jan 4, 2023
## [14.21.1](v14.21.0...v14.21.1) (2023-01-04)

### Bug Fixes

* Allow everyone to read geo data ([#19451](#19451)) ([#19457](#19457)) ([54eecce](54eecce))
* build_response for re.Match ([#19442](#19442)) ([c3729c7](c3729c7))
* don't set default in list view for fields not allowed ([373234d](373234d))
* **link/js:** handle undefined `link_title_doctypes` in `frappe.boot` ([#19398](#19398)) ([#19402](#19402)) ([f314e58](f314e58))
* only allow system manager to create email templates ([f46a649](f46a649))
* prevent emails from being queued multiple times ([#19386](#19386)) ([#19454](#19454)) ([21b84a4](21b84a4))
* show document title instead of name in like notification email subject ([41af70d](41af70d))
* **socketio:** Event list_update > doctype_subscribe (backport [#19422](#19422)) ([#19432](#19432)) ([4529e6d](4529e6d))
* **test:** override fields of test doctype if passed ([8a86a8c](8a86a8c))
* use title instead of name in message body too ([5878b53](5878b53))
stephenBDT pushed a commit to alias/frappe that referenced this pull request Jan 10, 2023
This is static data present in code, no need to apply permissions.

closes frappe#19394

(cherry picked from commit 5ece1d7)

Co-authored-by: Ankush Menat <ankush@frappe.io>
stephenBDT pushed a commit to alias/frappe that referenced this pull request Jan 10, 2023
## [14.21.1](frappe/frappe@v14.21.0...v14.21.1) (2023-01-04)

### Bug Fixes

* Allow everyone to read geo data ([frappe#19451](frappe#19451)) ([frappe#19457](frappe#19457)) ([54eecce](frappe@54eecce))
* build_response for re.Match ([frappe#19442](frappe#19442)) ([c3729c7](frappe@c3729c7))
* don't set default in list view for fields not allowed ([373234d](frappe@373234d))
* **link/js:** handle undefined `link_title_doctypes` in `frappe.boot` ([frappe#19398](frappe#19398)) ([frappe#19402](frappe#19402)) ([f314e58](frappe@f314e58))
* only allow system manager to create email templates ([f46a649](frappe@f46a649))
* prevent emails from being queued multiple times ([frappe#19386](frappe#19386)) ([frappe#19454](frappe#19454)) ([21b84a4](frappe@21b84a4))
* show document title instead of name in like notification email subject ([41af70d](frappe@41af70d))
* **socketio:** Event list_update > doctype_subscribe (backport [frappe#19422](frappe#19422)) ([frappe#19432](frappe#19432)) ([4529e6d](frappe@4529e6d))
* **test:** override fields of test doctype if passed ([8a86a8c](frappe@8a86a8c))
* use title instead of name in message body too ([5878b53](frappe@5878b53))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14 Skip CI Doesn't run Ci for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Phone number field is not accessible for guest users.
1 participant
0