8000 fix(error snapshot): fix seen update query in error snapshot to work with postgres by AHasanin · Pull Request #19373 · frappe/frappe · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(error snapshot): fix seen update query in error snapshot to work with postgres #19373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 20, 2022
Merged

fix(error snapshot): fix seen update query in error snapshot to work with postgres #19373

merged 1 commit into from
Dec 20, 2022

Conversation

AHasanin
Copy link
Contributor

problem:

  • When trying to view an error from error snapshot it will try to update the seen field of the record with true value , but it will give the following error in case of postgres because the type of seen field is int not boolean, it will work with mariadb but not postgres.

postgresql_errorsnapshot

solution:

  • Change update value from True to 1, False to 0 so it works with mariadb and posgres

@github-actions github-actions bot added the add-test-cases Add test case to validate fix or enhancement label Dec 20, 2022
@ankush ankush added backport version-14-hotfix backport to version 14 and removed add-test-cases Add test case to validate fix or enhancement labels Dec 20, 2022
@ankush ankush merged commit bb5e21d into frappe:develop Dec 20, 2022
@ankush ankush added the postgres postgres db related issue/PRs label Dec 20, 2022
@mergify mergify bot mentioned this pull request Dec 20, 2022
Merged
mergify bot pushed a commit that referenced this pull request Dec 20, 2022
@AHasanin @mergify
fix(error snapshot): fix seen update qeury in error snapshot to work …
6ca068a 
…with postgres (#19373)

[skip ci]

(cherry picked from commit bb5e21d)
ankush pushed a commit that referenced this pull request Dec 21, 2022
@mergify @AHasanin
fix(error snapshot): fix seen update qeury in error snapshot to work …
0ab6a30 
…with postgres (#19373) (#19374)

[skip ci]

(cherry picked from commit bb5e21d)

Co-authored-by: Ahmed Hasanin <52963581+AHasanin@users.noreply.github.com>
frappe-pr-bot pushed a commit that referenced this pull request Dec 27, 2022
@frappe-bot
chore(release): Bumped to Version 14.21.0
0a51eff 
# [14.21.0](v14.20.0...v14.21.0) (2022-12-27)

### Bug Fixes

* Allow emailing disabled user ([#19382](#19382)) ([#19383](#19383)) ([fb7f645](fb7f645))
* **error snapshot:** fix seen update qeury in error snapshot to work with postgres ([#19373](#19373)) ([#19374](#19374)) ([0ab6a30](0ab6a30))
* **minor:** dont set autoincrement autoname by default for child table ([8ff3f4c](8ff3f4c))
* not able to make delivery note from pick list ([#19418](#19418)) ([#19420](#19420)) ([d2d776c](d2d776c))
* shift-select checkboxes ranges ([#19367](#19367)) ([#19368](#19368)) ([bd79b03](bd79b03))
* **subscription:** Allow remote_login even if subscription.expiry is not set ([1d777dc](1d777dc))

### Features

* hook `ignore_links_on_delete` to skip doctypes on delete ([#19347](#19347)) ([#19356](#19356)) ([a457447](a457447))
developmentforpeople pushed a commit to developmentforpeople/frappe that referenced this pull request Jan 3, 2023
@mergify @AHasanin @developmentforpeople
fix(error snapshot): fix seen update qeury in error snapshot to work …
d65a2a4 
…with postgres (frappe#19373) (frappe#19374)

[skip ci]

(cherry picked from commit bb5e21d)

Co-authored-by: Ahmed Hasanin <52963581+AHasanin@users.noreply.github.com>
developmentforpeople pushed a commit to developmentforpeople/frappe that referenced this pull request Jan 3, 2023
@frappe-bot @developmentforpeople
chore(release): Bumped to Version 14.21.0
ec6b6a7 
# [14.21.0](frappe/frappe@v14.20.0...v14.21.0) (2022-12-27)

### Bug Fixes

* Allow emailing disabled user ([frappe#19382](frappe#19382)) ([frappe#19383](frappe#19383)) ([fb7f645](frappe@fb7f645))
* **error snapshot:** fix seen update qeury in error snapshot to work with postgres ([frappe#19373](frappe#19373)) ([frappe#19374](frappe#19374)) ([0ab6a30](frappe@0ab6a30))
* **minor:** dont set autoincrement autoname by default for child table ([8ff3f4c](frappe@8ff3f4c))
* not able to make delivery note from pick list ([frappe#19418](frappe#19418)) ([frappe#19420](frappe#19420)) ([d2d776c](frappe@d2d776c))
* shift-select checkboxes ranges ([frappe#19367](frappe#19367)) ([frappe#19368](frappe#19368)) ([bd79b03](frappe@bd79b03))
* **subscription:** Allow remote_login even if subscription.expiry is not set ([1d777dc](frappe@1d777dc))

### Features

* hook `ignore_links_on_delete` to skip doctypes on delete ([frappe#19347](frappe#19347)) ([frappe#19356](frappe#19356)) ([a457447](frappe@a457447))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ankush ankush ankush approved these changes

@surajshetty3416 surajshetty3416 Awaiting requested review from surajshetty3416

Assignees
No one assigned
Labels
backport version-14-hotfix backport to version 14 postgres postgres db related issue/PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AHasanin @ankush
0