8000 fix: log unknown usernames too for failed attempts by ankush · Pull Request #19199 · frappe/frappe · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: log unknown usernames too for failed attempts #19199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 8, 2022
Merged

fix: log unknown usernames too for failed attempts #19199

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion frappe/auth.py
View file
Open in desktop
< 47B4 td class="blob-code blob-code-context js-file-line">
Original file line number Diff line number Diff line change
Expand Up @@ -230,10 +230,11 @@ def authenticate(self, user: str = None, pwd: str = None):
if not (user and pwd):
self.fail(_("Incomplete login details"), user=user)

_raw_user_name = user
user = User.find_by_credentials(user, pwd)

if not user:
self.fail("Invalid login credentials")
self.fail("Invalid login credentials", user=_raw_user_name)
# Current login flow uses cached credentials for authentication while checking OTP.
# Incase of OTP check, tracker for auth needs to be disabled(If not, it can remove tracker history as it is going to succeed anyway)
Expand Down
0