8000 fix: stabilize shared with dialog by phot0n · Pull Request #19170 · frappe/frappe · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: stabilize shared with dialog #19170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 8, 2022
Merged

Conversation

phot0n
Copy link
Contributor
@phot0n phot0n commented Dec 7, 2022

This pr fixes the weird behavior of shared with dialog.

the main causes are:

  1. setting of multiple click events for opening shared with dialog
  2. no return value when setting share permissions (via frappe.share.set_permission) even though they're being used on the client side - this is used in updating the avatar on the form sidebar

Before:

Screencast.2022-12-08.00.47.52.mp4

After:

Screencast.2022-12-08.00.45.35.mp4

@phot0n phot0n force-pushed the fix-shared-with branch 2 times, most recently from 85ee810 to adb06c1 Compare December 7, 2022 18:32
@codecov
Copy link
codecov bot commented Dec 7, 2022

Codecov Report

Merging #19170 (19588b2) into develop (3885833) will increase coverage by 0.31%.
The diff coverage is 75.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #19170      +/-   ##
===========================================
+ Coverage    63.66%   63.98%   +0.31%     
===========================================
  Files          750      751       +1     
  Lines        67686    68659     +973     
  Branches      6039     6039              
===========================================
+ Hits         43093    43931     +838     
- Misses       21166    21301     +135     
  Partials      3427     3427              
Flag Coverage Δ
server 68.42% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@phot0n phot0n marked this pull request as ready for review December 7, 2022 19:19
@phot0n phot0n requested review from a team and shariquerik and removed request for a team December 7, 2022 19:19
@shariquerik shariquerik merged commit 0b2bc14 into frappe:develop Dec 8, 2022
phot0n added a commit that referenced this pull request Dec 8, 2022
* fix: stabilize shared with dialog

(cherry picked from commit 19588b2)

# Conflicts:
#	frappe/public/js/frappe/form/sidebar/share.js
#	frappe/share.py

* chore: resolve conflicts

Co-authored-by: phot0n <ritwikpuri5678@gmail.com>
frappe-pr-bot pushed a commit that referenced this pull request Dec 13, 2022
# [13.46.0](v13.45.3...v13.46.0) (2022-12-13)

### Bug Fixes

* attribute error on export of reports with additional columns ([#19105](#19105)) ([#19119](#19119)) ([da28290](da28290))
* do not rename select field options and values on doctype rename ([#19223](#19223)) ([#19225](#19225)) ([47f5fd0](47f5fd0))
* **docshare:** return None if share_name and value are None ([#19187](#19187)) ([#19188](#19188)) ([4e2620a](4e2620a))
* log unknown usernames too for failed attempts ([#19199](#19199)) ([#19200](#19200)) ([a75fa10](a75fa10))
* only make fetch_from field read only if no input (backport [#19192](#19192)) ([#19194](#19194)) ([994c1ed](994c1ed))
* reload shared dialog upon checking any perm (backport [#19196](#19196)) ([#19197](#19197)) ([fd44b34](fd44b34))
* set-config -g ([#19217](#19217)) ([#19218](#19218)) ([458707e](458707e))
* stabilize shared with dialog (backport [#19170](#19170)) ([#19185](#19185)) ([4f9d755](4f9d755))
* unscrub and translate field names in tooltip explaining fetch from (backport [#19143](#19143)) ([#19173](#19173)) ([fc430d1](fc430d1))
* **UX:** forget password shows error on wrong email ([#19235](#19235)) ([#19239](#19239)) ([5257ca7](5257ca7))
* workflow icon not visible in mobile view ([dcb3933](dcb3933))

### Features

* allow user to pick all columns ([#19236](#19236)) ([927b264](927b264))
* finer frappe Recorder control with decorator (backport [#19220](#19220)) ([#19221](#19221)) ([3b18e7e](3b18e7e))
* inter-process file locks ([#19133](#19133)) ([#19145](#19145)) ([b34e8ce](b34e8ce))

### Performance Improvements

* remove order_by from linked_with checks ([#19229](#19229)) ([#19242](#19242)) ([c2cde0c](c2cde0c))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0