8000 fix: (ctrl/cmd)+click for clickable divs by shariquerik · Pull Request #18910 · frappe/frappe · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: (ctrl/cmd)+click for clickable divs #18910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 17, 2022
Merged

fix: (ctrl/cmd)+click for clickable divs #18910

merged 1 commit into from
Nov 17, 2022

Conversation

shariquerik
Copy link
Member
@shariquerik shariquerik commented Nov 17, 2022 •
edited by uhrjun
Loading

Fixes: #18788

This PR makes following elements support cmd+click

  • Workspace Shortcut
  • Workspace Quick List
  • Awesomebar results
  • Menu items on any page

@shariquerik shariquerik requested review from a team and phot0n and removed request for a team November 17, 2022 08:32
@codecov
Copy link
codecov bot commented Nov 17, 2022

Codecov Report

Merging #18910 (8e0e2da) into develop (2faa8ef) will increase coverage by 0.00%.
The diff coverage is 40.90%.

Additional details and impacted files 
@@            Coverage Diff            @@
##           develop   #18910    +/-   ##
=========================================
  Coverage    63.45%   63.45%            
=========================================
  Files          750      750            
  Lines        67551    67809   +258     
  Branches      6018     6025     +7     
=========================================
+ Hits         42866    43030   +164     
- Misses       21224    21353   +129     
+ Partials      3461     3426    -35
Flag Coverage Δ
server-ui 31.61% <ø> (-0.03%) ⬇️
ui-tests 50.98% <40.90%> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@shariquerik shariquerik added the defer backport Backports for some PR are deferred for a week or two to test them properly before releasing label Nov 17, 2022
@shariquerik shariquerik merged commit 547cdcf into frappe:develop Nov 17, 2022
@shariquerik shariquerik deleted the cmd+click-for-div branch November 17, 2022 11:09
@shariquerik shariquerik mentioned this pull request Nov 17, 2022
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 2, 2022
@shariquerik shariquerik added backport version-14-hotfix backport to version 14 and removed defer backport Backports for some PR are deferred for a week or two to test them properly before releasing labels Jan 20, 2023
@mergify mergify bot mentioned this pull request Jan 20, 2023
Merged
@shariquerik
Copy link
Member Author

@Mergifyio backport version-14-hotfix

1 similar comment
@shariquerik
Copy link
Member Author

@Mergifyio backport version-14-hotfix

@frappe frappe unlocked this conversation Jan 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@phot0n phot0n Awaiting requested review from phot0n

Assignees
No one assigned
Labels
backport version-14-hotfix backport to version 14
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make ctrl+click work with most common clickable things
1 participant
@shariquerik
0