fix(file): set fieldname to table fieldname #18965
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because files are always attached to parent
shariquerik
requested changes
Nov 21, 2022
Co-authored-by: Shariq Ansari <30859809+shariquerik@users.noreply.github.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #18965 +/- ##
===========================================
- Coverage 63.49% 63.47% -0.02%
===========================================
Files 750 750
Lines 67593 67620 +27
Branches 6029 6027 -2
===========================================
+ Hits 42920 42924 +4
- Misses 21248 21260 +12
- Partials 3425 3436 +11
Flags with carried forward coverage won't be shown. Click here to find out more. |
This was referenced Nov 22, 2022
sagarvora
added a commit
to resilient-tech/frappe
that referenced
this pull request
Nov 30, 2022
ankush
pushed a commit
that referenced
this pull request
Nov 30, 2022
* fix: only check for special characters in fieldname * chore: revert #18965
ankush
pushed a commit
that referenced
this pull request
Nov 30, 2022
ankush
pushed a commit
that referenced
this pull request
Nov 30, 2022
ankush
pushed a commit
that referenced
this pull request
Nov 30, 2022
…#19067) * fix: only check for special characters in fieldname (#19061) * fix: only check for special characters in fieldname * chore: revert #18965 (cherry picked from commit 2e2f8e8) # Conflicts: # frappe/core/doctype/file/file.py * fix: backport #18909 and misc changes Co-authored-by: Sagar Vora <sagar@resilient.tech>
frappe-pr-bot
pushed a commit
that referenced
this pull request
Nov 30, 2022
mergify bot
added a commit
that referenced
this pull request
Nov 30, 2022
…#19067) * fix: only check for special characters in fieldname (#19061) * fix: only check for special characters in fieldname * chore: revert #18965 (cherry picked from commit 2e2f8e8) # Conflicts: # frappe/core/doctype/file/file.py * fix: backport #18909 and misc changes Co-authored-by: Sagar Vora <sagar@resilient.tech> (cherry picked from commit f68f161)
ankush
pushed a commit
that referenced
this pull request
Dec 1, 2022
…#19067) (#19069) * fix: only check for special characters in fieldname (#19061) * fix: only check for special characters in fieldname * chore: revert #18965 (cherry picked from commit 2e2f8e8) # Conflicts: # frappe/core/doctype/file/file.py * fix: backport #18909 and misc changes Co-authored-by: Sagar Vora <sagar@resilient.tech> (cherry picked from commit f68f161) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
frappe-pr-bot
pushed a commit
that referenced
this pull request
Dec 1, 2022
frappe-pr-bot
pushed a commit
that referenced
this pull request
Dec 6, 2022
# [14.18.0](v14.17.1...v14.18.0) (2022-12-06) ### Bug Fixes * attribute error on export of reports with additional columns ([#19105](#19105)) ([2b43d5b](2b43d5b)) * check for bad zip files during unzipping in file doctype ([#19058](#19058)) ([#19060](#19060)) ([96c928e](96c928e)) * **db_query:** Disallow usage of certain functions in *_by ([#18981](#18981)) ([#19135](#19135)) ([5376755](5376755)) * **db_query:** Space resilient sanitization (backport [#18996](#18996)) ([#19045](#19045)) ([ab8422f](ab8422f)) * disable signups by default (backport [#19114](#19114)) ([#19118](#19118)) ([3dd2775](3dd2775)) * do not escape undefined txt ([86267e9](86267e9)) * empty search shows `None` ([#19055](#19055)) ([#19057](#19057)) ([1cd0bc2](1cd0bc2)) * ensure correct parenttype when retrieving roles ([af55da9](af55da9)) * give more weight to sequential matches ([#19121](#19121)) ([#19122](#19122)) ([16f642f](16f642f)) * ignore empty/`None` scripts ([#19111](#19111)) ([#19113](#19113)) ([2a96757](2a96757)) * keep actions on right ([7d3e47b](7d3e47b)) * LDAP - check each email in list before creating user ([250f787](250f787)) * only check for special characters in fieldname ([#19061](#19061)) ([#19065](#19065)) ([de0facc](de0facc)), closes [#18965](#18965) * only System Manager can access Google Drive ([05be9ee](05be9ee)) * Optimize check field type is tab break if the doctype has a workflow ([#18858](#18858)) ([d9ce6c1](d9ce6c1)) * site creation using non-root users ([#19014](#19014)) ([#19043](#19043)) ([844e744](844e744)) * socketio spawn error ([#19070](#19070)) ([#19071](#19071)) ([75a54eb](75a54eb)) * type conversion for read receipt in communication email ([e0f7dd4](e0f7dd4)) * use permtype from passed arguments in has_web_form_permission when applying document permissions ([91c99d2](91c99d2)) * use webform doctype rather than allowing user to pass any doctype ([2be3178](2be3178)) * **UX:** freeze on delete ([#19094](#19094)) ([dd4791a](dd4791a)) * **UX:** Make fetch_from read_only if fetch_is_empty is not set ([#19025](#19025)) ([#19041](#19041)) ([feed227](feed227)) * Widget control on dashboard chart breaks on smaller screens ([d6dedca](d6dedca)) ### Features * **workers:** many small RQ worker features (backport [#18995](#18995)) ([#19046](#19046)) ([37dbada](37dbada))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR #18880 introduced
attached_to_fieldvalidation.When you upload a file in a Attach field inside child table, it is linked to the parent doctype. In this case, the attached_to_field must be the table fieldname for the validation to work properly.