8000 fix: only get fields which is not already in webform fields table by shariquerik · Pull Request #18960 · frappe/frappe · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: only get fields which is not already in webform fields table #18960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 21, 2022
Merged

fix: only get fields which is not already in webform fields table #18960

merged 1 commit into from
Nov 21, 2022

Conversation

shariquerik
Copy link
Member

Issue: When we click on get fields button all the fields are added to the web form fields table
Fix: Now fields which are not present in the webform fields table will be added.

@shariquerik shariquerik requested review from a team and phot0n and removed request for a team November 21, 2022 12:06
@shariquerik shariquerik added the backport version-14-hotfix backport to version 14 label Nov 21, 2022
@shariquerik
Copy link
Member Author

Skipping ci

@shariquerik shariquerik merged commit 5605e9d into frappe:develop Nov 21, 2022
@shariquerik shariquerik deleted the web-form-get-fields-fix branch November 21, 2022 12:06
@mergify mergify bot mentioned this pull request Nov 21, 2022
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@phot0n phot0n Awaiting requested review from phot0n

Assignees
No one assigned
Labels
backport version-14-hotfix backport to version 14
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shariquerik
0