feat(minor): redirect after login from NotPermittedPage (backport #18946) #18956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* redirect after login from NotPermittedPage (cherry picked from commit 4ec7d2d)
frappe-pr-bot
pushed a commit
that referenced
this pull request
Nov 22, 2022
# [14.16.0](v14.15.0...v14.16.0) (2022-11-22) ### Bug Fixes * added phone field in webform ([c47b88c](c47b88c)) * Auto-add all users to website room ([bf4fdca](bf4fdca)) * check permission in discussions component ([#18903](#18903)) ([6a47669](6a47669)) * **desk:** maintain realtime & cached data consistency ([117f1f7](117f1f7)) * dont convert row format if not required ([#18900](#18900)) ([#18901](#18901)) ([9394677](9394677)) * **file:** attached_to_name can be an integer ([#18909](#18909)) ([#18911](#18911)) ([3b112e1](3b112e1)) * **file:** set fieldname to table fieldname ([14b6017](14b6017)) * **File:** validate `attached_to_*` when saving ([#18882](#18882)) ([5fe9f3c](5fe9f3c)) * Force integer type in request.max_content_length (backport [#18904](#18904)) ([#18931](#18931)) ([5e13b08](5e13b08)) * get_title must return string ([#18926](#18926)) ([#18935](#18935)) ([8d6f23c](8d6f23c)) * grid column indicators not working ([e2a1274](e2a1274)) * ignore unpicklable hooks ([#18902](#18902)) ([#18932](#18932)) ([bb660a1](bb660a1)) * only get fields which is not already in webform fields table ([380dc06](380dc06)) * **recorder:** Publish update only to Administrator ([1c09bee](1c09bee)) * Restrict socket data to respective users after commit ([efe4d2d](efe4d2d)) * show fields without labels in print format builder ([#18939](#18939)) ([#18955](#18955)) ([0e384d8](0e384d8)) * **socketio:** Re-try thrice before trying to reconnect ([1c72d92](1c72d92)) * **socketio:** Revert irrelevant & unused changes ([62f5e67](62f5e67)) * **socketio:** Scoping & hoisting bugs ([0a1fdbb](0a1fdbb)) * succinct version ([85e0d85](85e0d85)) * update-password api call ([#18943](#18943)) ([#18953](#18953)) ([4eeeccd](4eeeccd)) ### Features * {site}:website room open to all users ([965a814](965a814)) * **minor:** redirect after login from NotPermittedPage ([#18946](#18946)) ([#18956](#18956)) ([2ea12db](2ea12db)) ### Performance Improvements * dont fetch meta unless required ([#18907](#18907)) ([#18908](#18908)) ([02dae2d](02dae2d)) * **socketio:** get_site_name ([422882c](422882c))
|
🎉 This PR is included in version 14.16.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
stephenBDT
pushed a commit
to alias/frappe
that referenced
this pull request
Nov 30, 2022
frappe#18956) * redirect after login from NotPermittedPage (cherry picked from commit 4ec7d2d) Co-authored-by: PeterG <this-gavagai@users.noreply.github.com>
stephenBDT
pushed a commit
to alias/frappe
that referenced
this pull request
Nov 30, 2022
# [14.16.0](frappe/frappe@v14.15.0...v14.16.0) (2022-11-22) ### Bug Fixes * added phone field in webform ([c47b88c](frappe@c47b88c)) * Auto-add all users to website room ([bf4fdca](frappe@bf4fdca)) * check permission in discussions component ([frappe#18903](frappe#18903)) ([6a47669](frappe@6a47669)) * **desk:** maintain realtime & cached data consistency ([117f1f7](frappe@117f1f7)) * dont convert row format if not required ([frappe#18900](frappe#18900)) ([frappe#18901](frappe#18901)) ([9394677](frappe@9394677)) * **file:** attached_to_name can be an integer ([frappe#18909](frappe#18909)) ([frappe#18911](frappe#18911)) ([3b112e1](frappe@3b112e1)) * **file:** set fieldname to table fieldname ([14b6017](frappe@14b6017)) * **File:** validate `attached_to_*` when saving ([frappe#18882](frappe#18882)) ([5fe9f3c](frappe@5fe9f3c)) * Force integer type in request.max_content_length (backport [frappe#18904](frappe#18904)) ([frappe#18931](frappe#18931)) ([5e13b08](frappe@5e13b08)) * get_title must return string ([frappe#18926](frappe#18926)) ([frappe#18935](frappe#18935)) ([8d6f23c](frappe@8d6f23c)) * grid column indicators not working ([e2a1274](frappe@e2a1274)) * ignore unpicklable hooks ([frappe#18902](frappe#18902)) ([frappe#18932](frappe#18932)) ([bb660a1](frappe@bb660a1)) * only get fields which is not already in webform fields table ([380dc06](frappe@380dc06)) * **recorder:** Publish update only to Administrator ([1c09bee](frappe@1c09bee)) * Restrict socket data to respective users after commit ([efe4d2d](frappe@efe4d2d)) * show fields without labels in print format builder ([frappe#18939](frappe#18939)) ([frappe#18955](frappe#18955)) ([0e384d8](frappe@0e384d8)) * **socketio:** Re-try thrice before trying to reconnect ([1c72d92](frappe@1c72d92)) * **socketio:** Revert irrelevant & unused changes ([62f5e67](frappe@62f5e67)) * **socketio:** Scoping & hoisting bugs ([0a1fdbb](frappe@0a1fdbb)) * succinct version ([85e0d85](frappe@85e0d85)) * update-password api call ([frappe#18943](frappe#18943)) ([frappe#18953](frappe#18953)) ([4eeeccd](frappe@4eeeccd)) ### Features * {site}:website room open to all users ([965a814](frappe@965a814)) * **minor:** redirect after login from NotPermittedPage ([frappe#18946](frappe#18946)) ([frappe#18956](frappe#18956)) ([2ea12db](frappe@2ea12db)) ### Performance Improvements * dont fetch meta unless required ([frappe#18907](frappe#18907)) ([frappe#18908](frappe#18908)) ([02dae2d](frappe@02dae2d)) * **socketio:** get_site_name ([422882c](frappe@422882c))
stephenBDT
pushed a commit
to alias/frappe
that referenced
this pull request
Dec 1, 2022
frappe#18956) * redirect after login from NotPermittedPage (cherry picked from commit 4ec7d2d) Co-authored-by: PeterG <this-gavagai@users.noreply.github.com>
stephenBDT
pushed a commit
to alias/frappe
that referenced
this pull request
Dec 1, 2022
# [14.16.0](frappe/frappe@v14.15.0...v14.16.0) (2022-11-22) ### Bug Fixes * added phone field in webform ([c47b88c](frappe@c47b88c)) * Auto-add all users to website room ([bf4fdca](frappe@bf4fdca)) * check permission in discussions component ([frappe#18903](frappe#18903)) ([6a47669](frappe@6a47669)) * **desk:** maintain realtime & cached data consistency ([117f1f7](frappe@117f1f7)) * dont convert row format if not required ([frappe#18900](frappe#18900)) ([frappe#18901](frappe#18901)) ([9394677](frappe@9394677)) * **file:** attached_to_name can be an integer ([frappe#18909](frappe#18909)) ([frappe#18911](frappe#18911)) ([3b112e1](frappe@3b112e1)) * **file:** set fieldname to table fieldname ([14b6017](frappe@14b6017)) * **File:** validate `attached_to_*` when saving ([frappe#18882](frappe#18882)) ([5fe9f3c](frappe@5fe9f3c)) * Force integer type in request.max_content_length (backport [frappe#18904](frappe#18904)) ([frappe#18931](frappe#18931)) ([5e13b08](frappe@5e13b08)) * get_title must return string ([frappe#18926](frappe#18926)) ([frappe#18935](frappe#18935)) ([8d6f23c](frappe@8d6f23c)) * grid column indicators not working ([e2a1274](frappe@e2a1274)) * ignore unpicklable hooks ([frappe#18902](frappe#18902)) ([frappe#18932](frappe#18932)) ([bb660a1](frappe@bb660a1)) * only get fields which is not already in webform fields table ([380dc06](frappe@380dc06)) * **recorder:** Publish update only to Administrator ([1c09bee](frappe@1c09bee)) * Restrict socket data to respective users after commit ([efe4d2d](frappe@efe4d2d)) * show fields without labels in print format builder ([frappe#18939](frappe#18939)) ([frappe#18955](frappe#18955)) ([0e384d8](frappe@0e384d8)) * **socketio:** Re-try thrice before trying to reconnect ([1c72d92](frappe@1c72d92)) * **socketio:** Revert irrelevant & unused changes ([62f5e67](frappe@62f5e67)) * **socketio:** Scoping & hoisting bugs ([0a1fdbb](frappe@0a1fdbb)) * succinct version ([85e0d85](frappe@85e0d85)) * update-password api call ([frappe#18943](frappe#18943)) ([frappe#18953](frappe#18953)) ([4eeeccd](frappe@4eeeccd)) ### Features * {site}:website room open to all users ([965a814](frappe@965a814)) * **minor:** redirect after login from NotPermittedPage ([frappe#18946](frappe#18946)) ([frappe#18956](frappe#18956)) ([2ea12db](frappe@2ea12db)) ### Performance Improvements * dont fetch meta unless required ([frappe#18907](frappe#18907)) ([frappe#18908](frappe#18908)) ([02dae2d](frappe@02dae2d)) * **socketio:** get_site_name ([422882c](frappe@422882c))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #18946 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com