8000 perf(workflow): get_transitions (backport #18834) by mergify[bot] · Pull Request #18838 · frappe/frappe · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

perf(workflow): get_transitions (backport #18834) #18838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 14, 2022
Merged

perf(workflow): get_transitions (backport #18834) #18838

merged 2 commits into from
Nov 14, 2022

Conversation

mergify[bot]
Copy link
Contributor
@mergify mergify bot commented Nov 10, 2022

This is an automatic backport of pull request #18834 done by Mergify.

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@gavindsouza @mergify
perf(workflow): get_transitions (#18834)
9ec557d 
* Load from db only if doc passed is not of type Document. This was
  added earlier to load in case of dicts. ref: #11883
* Move blocks to evaluate only if required
* Add typing hints

(cherry picked from commit a093b7b)
@mergify mergify bot requested review from a team and phot0n and removed request for a team November 10, 2022 11:03
gavindsouza
gavindsouza reviewed Nov 10, 2022
View reviewed changes
Copy link
Collaborator
@gavindsouza gavindsouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix: Use backwards compatible types

@gavindsouza gavindsouza merged commit 5545dd2 into version-13-hotfix Nov 14, 2022
@ankush ankush deleted the mergify/bp/version-13-hotfix/pr-18834 branch November 14, 2022 07:18
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 13.44.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gavindsouza gavindsouza gavindsouza approved these changes

@phot0n phot0n Awaiting requested review from phot0n

Assignees

@gavindsouza gavindsouza

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frappe-pr-bot @gavindsouza
0