8000 fix: webform read only field not working by shariquerik · Pull Request #18894 · frappe/frappe · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: webform read only field not working #18894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 16, 2022

Conversation

shariquerik
Copy link
Member

In Web Form, read-only fields are not working

Before:
image

After:
image

@shariquerik shariquerik requested review from a team and phot0n and removed request for a team November 16, 2022 10:32
@codecov
Copy link
codecov bot commented Nov 16, 2022

Codecov Report

Merging #18894 (990dcc7) into develop (0d5d2cf) will increase coverage by 0.11%.
The diff coverage is 0.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #18894      +/-   ##
===========================================
+ Coverage    63.45%   63.57%   +0.11%     
===========================================
  Files          750      750              
  Lines        67551    67551              
  Branches      6018     6019       +1     
===========================================
+ Hits         42865    42945      +80     
+ Misses       21225    21214      -11     
+ Partials      3461     3392      -69     
Flag Coverage Δ
server-ui 31.62% <ø> (-0.01%) ⬇️
ui-tests 51.01% <0.00%> (+0.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@shariquerik shariquerik added backport version-14-hotfix backport to version 14 defer backport Backports for some PR are deferred for a week or two to test them properly before releasing and removed backport version-14-hotfix backport to version 14 labels Nov 16, 2022
@shariquerik shariquerik merged commit 2faa8ef into frappe:develop Nov 16, 2022
@shariquerik shariquerik deleted the web-form-read-only branch November 16, 2022 12:26
@ankush ankush added backport version-14-hotfix backport to version 14 and removed defer backport Backports for some PR are deferred for a week or two to test them properly before releasing labels Nov 28, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0