fix(UX): allow clicking on row to open in new tab (backport #18789) #18790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frappe-pr-bot
pushed a commit
that referenced
this pull request
Nov 8, 2022
## [14.14.3](v14.14.2...v14.14.3) (2022-11-08) ### Bug Fixes * check permission before print or download document ([#18757](#18757)) ([#18785](#18785)) ([9b5225f](9b5225f)) * child table don't run mobile specific code ([d9af38b](d9af38b)) * dont close static modal with keyboard ([3e45d80](3e45d80)) * encode docname when routing (backport [#17092](#17092)) ([#17374](#17374)) ([#18748](#18748)) ([9fbccc7](9fbccc7)) * file cropper broken in webform ([e4bb26e](e4bb26e)) * hide value only if it's equal to the label ([#18722](#18722)) ([#18723](#18723)) ([e88f950](e88f950)) * ignore global translations ([#18733](#18733)) ([#18735](#18735)) ([5f36923](5f36923)) * load `doc_before_save` in `check_if_latest` ([#18752](#18752)) ([#18753](#18753)) ([243cfa3](243cfa3)) * **meta:** ensure that `insert_after` is always considered when sorting fields ([#18682](#18682)) ([2f0de9a](2f0de9a)) * not able to click checkbox in file grid view ([8f2e428](8f2e428)) * remove redundant translation ([#18775](#18775)) ([#18780](#18780)) ([a27c42e](a27c42e)) * search.py after PR [#17828](#17828) ([#18719](#18719)) ([#18721](#18721)) ([d5f39ea](d5f39ea)) * show 0 for empty currency, float, & duration fields in list view ([6edbbd4](6edbbd4)) * standard dashboards not loading ([ee1fb87](ee1fb87)) * translations ([#18765](#18765)) ([#18782](#18782)) ([aa68138](aa68138)) * **UX:** allow clicking on row to open in new tab ([#18789](#18789)) ([#18790](#18790)) ([f7d9d43](f7d9d43)) ### Performance Improvements * load `_doc_before_save` sooner to avoid DB call in `check_if_latest` ([#18666](#18666)) ([2710d08](2710d08))
|
🎉 This PR is included in version 14.14.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
stephenBDT
pushed a commit
to alias/frappe
that referenced
this pull request
Nov 11, 2022
…ppe#18790) - ctrl+click on row is toggling checkbox instead of opening it in new row - This only happens on non-mac devices Root cause: incorrect grouping of predicate towards fixing frappe#18788 [skip ci] (cherry picked from commit b2860e6) Co-authored-by: Ankush Menat <ankush@frappe.io>
stephenBDT
pushed a commit
to alias/frappe
that referenced
this pull request
Nov 11, 2022
## [14.14.3](frappe/frappe@v14.14.2...v14.14.3) (2022-11-08) ### Bug Fixes * check permission before print or download document ([frappe#18757](frappe#18757)) ([frappe#18785](frappe#18785)) ([9b5225f](frappe@9b5225f)) * child table don't run mobile specific code ([d9af38b](frappe@d9af38b)) * dont close static modal with keyboard ([3e45d80](frappe@3e45d80)) * encode docname when routing (backport [frappe#17092](frappe#17092)) ([frappe#17374](frappe#17374)) ([frappe#18748](frappe#18748)) ([9fbccc7](frappe@9fbccc7)) * file cropper broken in webform ([e4bb26e](frappe@e4bb26e)) * hide value only if it's equal to the label ([frappe#18722](frappe#18722)) ([frappe#18723](frappe#18723)) ([e88f950](frappe@e88f950)) * ignore global translations ([frappe#18733](frappe#18733)) ([frappe#18735](frappe#18735)) ([5f36923](frappe@5f36923)) * load `doc_before_save` in `check_if_latest` ([frappe#18752](frappe#18752)) ([frappe#18753](frappe#18753)) ([243cfa3](frappe@243cfa3)) * **meta:** ensure that `insert_after` is always considered when sorting fields ([frappe#18682](frappe#18682)) ([2f0de9a](frappe@2f0de9a)) * not able to click checkbox in file grid view ([8f2e428](frappe@8f2e428)) * remove redundant translation ([frappe#18775](frappe#18775)) ([frappe#18780](frappe#18780)) ([a27c42e](frappe@a27c42e)) * search.py after PR [frappe#17828](frappe#17828) ([frappe#18719](frappe#18719)) ([frappe#18721](frappe#18721)) ([d5f39ea](frappe@d5f39ea)) * show 0 for empty currency, float, & duration fields in list view ([6edbbd4](frappe@6edbbd4)) * standard dashboards not loading ([ee1fb87](frappe@ee1fb87)) * translations ([frappe#18765](frappe#18765)) ([frappe#18782](frappe#18782)) ([aa68138](frappe@aa68138)) * **UX:** allow clicking on row to open in new tab ([frappe#18789](frappe#18789)) ([frappe#18790](frappe#18790)) ([f7d9d43](frappe@f7d9d43)) ### Performance Improvements * load `_doc_before_save` sooner to avoid DB call in `check_if_latest` ([frappe#18666](frappe#18666)) ([2710d08](frappe@2710d08))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #18789 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com