8000 test: bg jobs test cleanup by ankush · Pull Request #18767 · frappe/frappe · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

test: bg jobs test cleanup #18767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 5, 2022
Merged

test: bg jobs test cleanup #18767

merged 5 commits into from
Nov 5, 2022

Conversation

ankush
Copy link
Member
@ankush ankush commented Nov 5, 2022 •
edited
Loading
  • Fix flaky RQ job tests
  • Bump RQ to latest version
  • Sanity test for all scheduled jobs
  • Avoid polluting Bench ID globally for few tests
  • Avoid throwing exception from stop_job

@ankush ankush added the defer backport Backports for some PR are deferred for a week or two to test them properly before releasing label Nov 5, 2022
ankush added 4 commits November 5, 2022 12:53
@ankush
test: fix flaky RQ job tests
deb84af 
Sometimes stop_job doesn't succeed and causes tests to timeout. Reduced
sleep time to avoid this in tests. We are still testing all the
important features - monitoring.
@ankush
build(deps): Bump RQ to latest version
5809459 
Minor bugfixes that affect us

ref: https://github.com/rq/rq/releases
@ankush
test: sanity tests for scheduled job types
65323b0
@ankush
test(test_runner): dont set bench_id globally
0c2921b
@codecov
Copy link
codecov bot commented Nov 5, 2022 •
edited
Loading

Codecov Report

Merging #18767 (4647b2f) into develop (ba25e97) will increase coverage by 0.06%.
The diff coverage is 66.66%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #18767      +/-   ##
===========================================
+ Coverage    63.09%   63.16%   +0.06%     
===========================================
  Files          747      747              
  Lines        68383    67293    -1090     
  Branches      5995     5999       +4     
===========================================
- Hits         43148    42505     -643     
+ Misses       21753    21321     -432     
+ Partials      3482     3467      -15
Flag Coverage Δ
server-mariadb 67.30% <66.66%> (+0.04%) ⬆️
server-postgres 67.31% <66.66%> (+0.02%) ⬆️
server-ui 31.20% <0.00%> (+<0.01%) ⬆️
ui-tests 50.23% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ankush
refactor: stop_job shouldn't throw error
4647b2f 
The intention of use here is to stop stuck jobs or long running jobs, if
for some reason they were stopped by the time command gets executed,
there's no need to throw error.
@ankush ankush marked this pull request as ready for review November 5, 2022 08:38
@ankush ankush requested review from a team and phot0n and removed request for a team November 5, 2022 08:38
@ankush ankush merged commit 032df94 into frappe:develop Nov 5, 2022
@ankush ankush deleted the moar_tests branch November 5, 2022 08:38
@ankush ankush added backport version-14-hotfix backport to version 14 and removed defer backport Backports for some PR are deferred for a week or two to test them properly before releasing labels Nov 8, 2022
@mergify mergify bot mentioned this pull request Nov 8, 2022
Merged
mergify bot pushed a commit that referenced this pull request Nov 8, 2022
@ankush @mergify
test: bg jobs test cleanup (#18767)
47b02ab 
* test: fix flaky RQ job tests

Sometimes stop_job doesn't succeed and causes tests to timeout. Reduced
sleep time to avoid this in tests. We are still testing all the
important features - monitoring.

* build(deps): Bump RQ to latest version

Minor bugfixes that affect us

ref: https://github.com/rq/rq/releases

* test: sanity tests for scheduled job types

* test(test_runner): dont set bench_id globally

* refactor: stop_job shouldn't throw error

The intention of use here is to stop stuck jobs or long running jobs, if
for some reason they were stopped by the time command gets executed,
there's no need to throw error.

(cherry picked from commit 032df94)

# Conflicts:
#	frappe/core/doctype/rq_job/test_rq_job.py
ankush added a commit that referenced this pull request Nov 8, 2022
@ankush
Merge pull request #18805 from frappe/mergify/bp/version-14-hotfix/pr…
a2fbe1f 
…-18767

test: bg jobs test cleanup (backport #18767)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@surajshetty3416 surajshetty3416 Awaiting requested review from surajshetty3416

@phot0n phot0n Awaiting requested review from phot0n

Assignees
No one assigned
Labels
backport version-14-hotfix backport to version 14
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ankush
0