-
Notifications
You must be signed in to change notification settings - Fork 3.9k
fix: handle isatty correctly #18277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
fix: handle isatty correctly #18277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sys.stdin can be `None` [skip ci]
mergify bot
pushed a commit
that referenced
this pull request
Oct 3, 2022
sys.stdin can be `None` [skip ci] (cherry picked from commit 35ba00a)
ankush
added a commit
that referenced
this pull request
Oct 3, 2022
mergify bot
pushed a commit
that referenced
this pull request
Oct 3, 2022
sys.stdin can be `None` [skip ci] (cherry picked from commit 35ba00a) # Conflicts: # frappe/__init__.py
ankush
added a commit
that referenced
this pull request
Oct 3, 2022
frappe-pr-bot
pushed a commit
that referenced
this pull request
Oct 4, 2022
## [13.41.4](v13.41.3...v13.41.4) (2022-10-04) ### Bug Fixes * Chart date format on x-axis is inaccurate ([#18191](#18191)) ([a5144fb](a5144fb)) * Chart filter not working if not operator is used (backport [#18194](#18194)) ([#18264](#18264)) ([a04436f](a04436f)) * handle isatty correctly (backport [#18277](#18277)) ([#18279](#18279)) ([3516dc4](3516dc4)) * only allow verified_command on GET requests ([#18235](#18235)) ([#18237](#18237)) ([3d2d07b](3d2d07b)) * remove return statement from override_email_send hook logic ([909fe12](909fe12)) * throw exception if backup failed ([#18230](#18230)) ([#18254](#18254)) ([96bae57](96bae57)) * typeError ([281d14d](281d14d)) ### Performance Improvements * use `modified` instead of `creation` in scheduler ([#18234](#18234)) ([#18239](#18239)) ([847b30e](847b30e))
frappe-pr-bot
pushed a commit
that referenced
this pull request
Oct 4, 2022
# [14.10.0](v14.9.0...v14.10.0) (2022-10-04) ### Bug Fixes * add translate function to some strings (backport [#18188](#18188)) ([#18242](#18242)) ([c929fe6](c929fe6)) * Chart date format on x-axis is inaccurate ([#18191](#18191)) ([#18207](#18207)) ([f940c7b](f940c7b)) * Chart filter not working if not operator is used (backport [#18194](#18194)) ([#18265](#18265)) ([775ed71](775ed71)) * **Data Import:** don't validate empty values ([#17923](#17923)) ([#18275](#18275)) ([26bfbf0](26bfbf0)) * dont assume issingle exists ([#18236](#18236)) ([#18252](#18252)) ([6164921](6164921)) * geolocation ([#18250](#18250)) ([#18282](#18282)) ([3e70643](3e70643)) * handle isatty correctly ([#18277](#18277)) ([#18278](#18278)) ([7ce396e](7ce396e)) * ignore child tables when init-ing parent doc ([84a58b3](84a58b3)) * **minor:** More button in list view ([#18283](#18283)) ([#18284](#18284)) ([99b8bbd](99b8bbd)) * only allow verified_command on GET requests ([#18235](#18235)) ([#18238](#18238)) ([d974143](d974143)) * report generation - frappe monitor ([#18259](#18259)) ([#18260](#18260)) ([d860e20](d860e20)) * throw exception if backup failed ([#18230](#18230)) ([#18255](#18255)) ([0f71fd2](0f71fd2)) ### Features * Added Subscription Banner for remotely logging into FrappeCloud dashboard from site ([#18263](#18263)) ([68f315d](68f315d)) ### Performance Improvements * use `modified` instead of `creation` in scheduler ([#18234](#18234)) ([#18240](#18240)) ([6245b91](6245b91))
stephenBDT
pushed a commit
to alias/frappe
that referenced
this pull request
Oct 11, 2022
sys.stdin can be `None` [skip ci] (cherry picked from commit 35ba00a) Co-authored-by: Ankush Menat <ankush@frappe.io>
stephenBDT
pushed a commit
to alias/frappe
that referenced
this pull request
Oct 11, 2022
# [14.10.0](frappe/frappe@v14.9.0...v14.10.0) (2022-10-04) ### Bug Fixes * add translate function to some strings (backport [frappe#18188](frappe#18188)) ([frappe#18242](frappe#18242)) ([c929fe6](frappe@c929fe6)) * Chart date format on x-axis is inaccurate ([frappe#18191](frappe#18191)) ([frappe#18207](frappe#18207)) ([f940c7b](frappe@f940c7b)) * Chart filter not working if not operator is used (backport [frappe#18194](frappe#18194)) ([frappe#18265](frappe#18265)) ([775ed71](frappe@775ed71)) * **Data Import:** don't validate empty values ([frappe#17923](frappe#17923)) ([frappe#18275](frappe#18275)) ([26bfbf0](frappe@26bfbf0)) * dont assume issingle exists ([frappe#18236](frappe#18236)) ([frappe#18252](frappe#18252)) ([6164921](frappe@6164921)) * geolocation ([frappe#18250](frappe#18250)) ([frappe#18282](frappe#18282)) ([3e70643](frappe@3e70643)) * handle isatty correctly ([frappe#18277](frappe#18277)) ([frappe#18278](frappe#18278)) ([7ce396e](frappe@7ce396e)) * ignore child tables when init-ing parent doc ([84a58b3](frappe@84a58b3)) * **minor:** More button in list view ([frappe#18283](frappe#18283)) ([frappe#18284](frappe#18284)) ([99b8bbd](frappe@99b8bbd)) * only allow verified_command on GET requests ([frappe#18235](frappe#18235)) ([frappe#18238](frappe#18238)) ([d974143](frappe@d974143)) * report generation - frappe monitor ([frappe#18259](frappe#18259)) ([frappe#18260](frappe#18260)) ([d860e20](frappe@d860e20)) * throw exception if backup failed ([frappe#18230](frappe#18230)) ([frappe#18255](frappe#18255)) ([0f71fd2](frappe@0f71fd2)) ### Features * Added Subscription Banner for remotely logging into FrappeCloud dashboard from site ([frappe#18263](frappe#18263)) ([68f315d](frappe@68f315d)) ### Performance Improvements * use `modified` instead of `creation` in scheduler ([frappe#18234](frappe#18234)) ([frappe#18240](frappe#18240)) ([6245b91](frappe@6245b91))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sys.stdin can be
None
when underlying fd is not valid.ref: jupyter/notebook#2454