fix: correct index syncing #18262
Merged
fix: correct index syncing #18262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fa251bd to
6bb28e9
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #18262 +/- ##
===========================================
- Coverage 62.68% 62.51% -0.17%
===========================================
Files 746 744 -2
Lines 67327 67717 +390
Branches 5965 5962 -3
===========================================
+ Hits 42206 42336 +130
- Misses 21630 21852 +222
- Partials 3491 3529 +38
Flags with carried forward coverage won't be shown. Click here to find out more. |
6bb28e9 to
1d8f58c
Compare
The implementation of syncing unique and non-unique index depended on index names which used to be different before because of that there's tendency to incorrectly identify index. This PR adds a separate util for checking if a column has index without relying on naming convention. It just goes and checks if there's any index with that column in it, hence far more reliable.
1d8f58c to
da561c2
Compare
ankush
added a commit
that referenced
this pull request
Oct 6, 2022
…-18262 fix: correct index syncing (backport #18262)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of syncing unique and non-unique index depended on
index names which used to be different before because of that there's
tendency to incorrectly identify index.
This PR adds a separate util for checking if a column has index without
relying on naming convention. It just goes and checks if there's any
index with that column in it, hence far more reliable.
Caused by #15680
PS: This also fixes issue where columns having search + unique index were not dropped automatically.