8000 feat: support list view for "show titles instead of name" by Tom-Finke · Pull Request #18060 · frappe/frappe · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: support list view for "show titles instead of name" #18060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 10, 2022
Merged

feat: support list view for "show titles instead of name" #18060

merged 10 commits into from
Oct 10, 2022

Conversation

Tom-Finke
Copy link
Contributor
@Tom-Finke Tom-Finke commented Sep 8, 2022 •
edited by nextchamp-saqib
Loading

Continues #17130
Closes #18059

no-docs

@Tom-Finke Tom-Finke requested review from a team and ankush and removed request for a team September 8, 2022 10:00
@Tom-Finke Tom-Finke mentioned this pull request Sep 8, 2022
Closed
@codecov
Copy link
codecov bot commented Sep 12, 2022 •
edited
Loading

Codecov Report

Merging #18060 (04f342a) into develop (627302d) will increase coverage by 0.06%.
The diff coverage is 84.21%.

❗ Current head 04f342a differs from pull request most recent head ab0149d. Consider uploading reports for the commit ab0149d to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #18060      +/-   ##
===========================================
+ Coverage    62.63%   62.70%   +0.06%     
===========================================
  Files          744      745       +1     
  Lines        67393    67412      +19     
  Branches      5962     5968       +6     
===========================================
+ Hits         42214    42268      +54     
+ Misses       21652    21627      -25     
+ Partials      3527     3517      -10
Flag Coverage Δ
server-ui 29.92% <ø> (+0.06%) ⬆️
ui-tests 49.74% <84.21%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ankush ankush changed the title Listview link titles feat: support list view for "show titles instead of name" Sep 15, 2022
@ankush ankush added the squash label Sep 15, 2022
@shariquerik shariquerik added the add-visuals add before and after images/ gifs to describe the fix/ feature label Sep 21, 2022
@stale stale bot added the inactive label Sep 30, 2022
@nextchamp-saqib
Copy link
Member

keep alive

@stale stale bot removed the inactive label Sep 30, 2022
@frappe frappe deleted a comment from stale bot Sep 30, 2022
@nextchamp-saqib
Copy link
Member
nextchamp-saqib commented Sep 30, 2022 •
edited
Loading

Works!

Form with Show Link Title enabled

CleanShot 2022-09-30 at 11 29 40@2x

List View Before:

CleanShot 2022-09-30 at 11 30 07@2x

After:

CleanShot 2022-09-30 at 11 29 49@2x

@nextchamp-saqib nextchamp-saqib removed the add-visuals add before and after images/ gifs to describe the fix/ feature label Sep 30, 2022
@stale stale bot added the inactive label Oct 8, 2022
@nextchamp-saqib
Copy link
Member
nextchamp-saqib commented Oct 9, 2022 8000

Keep alive x2

@frappe frappe deleted a comment from stale bot Oct 9, 2022
@ankush ankush merged commit 42f6aa6 into frappe:develop Oct 10, 2022
@ankush ankush mentioned this pull request Oct 10, 2022
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2022
@ankush ankush added the backport version-14-hotfix backport to version 14 label Oct 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ankush ankush Awaiting requested review from ankush

@nextchamp-saqib nextchamp-saqib Awaiting requested review from nextchamp-saqib

Assignees
No one assigned
Labels
backport version-14-hotfix backport to version 14 squash
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Link Titles in List View
4 participants
@Tom-Finke @nextchamp-saqib @ankush @shariquerik
0