-
Notifications
You must be signed in to change notification settings - Fork 3.9k
feat: add video conferencing option (Google Meet) to Google Calendar integration #17851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
25b1414
feat: add video conferencing (via google meet) for events syncing wit…
akurungadam 435a3c3
fix: unset add_video_conferencing if sync_with_google_calendar not en…
akurungadam 984159c
fix: remove conference data if add_video_conferencing disabled during…
akurungadam f3e3d5f
fix: restrict add conferencing if event_category in Event, Meeting an…
akurungadam 555f8f5
fix: save meet link while pulling from calendar
akurungadam f5e476b
feat: show link to join video conference with google meet
akurungadam c002a77
fix(style): linter errors
akurungadam b30ae52
fix(style): linter errors
akurungadam 142c0aa
fix: set conferenceDataVersion 1 only if google meet conferencing ena…
akurungadam 45035ec
Update frappe/desk/doctype/event/event.py
akurungadam 4e7afbe
Update frappe/desk/doctype/event/event.json
akurungadam 32321a8
fix: handle empty ends_on, use starts_on
akurungadam e867a42
fix: do not update Event modified time on db set meet link
akurungadam 63e8797
fix: add email field event participants table
akurungadam 13cadca
fix: attendees not cleared from google calendar event
akurungadam 2810666
fix(style): linter suggestions
akurungadam ad796f0
fix: make email field non-read only, called set_participants_email fr…
phot0n 44c5bdf
test: update new no of fields in event doctype in test_fetch_to_custo…
phot0n File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6D47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
2FC1
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't really need this variable over here right? we can just say if doc.add_video_conferencing is there, we need a meet link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this i guess we should go with the variable as it wouldn't be so obvious if we use the add_video_conferencing flag to be passed as the version?