fix: stabilize leaflet map #16513
Merged
fix: stabilize leaflet map #16513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- disable flyToBounds - invalidateSize after loading to avoid gray tiles
Codecov Report
@@ Coverage Diff @@
## develop #16513 +/- ##
===========================================
+ Coverage 56.65% 57.00% +0.35%
===========================================
Files 756 756
Lines 67243 67242 -1
Branches 5799 5798 -1
===========================================
+ Hits 38099 38334 +235
+ Misses 25400 25393 -7
+ Partials 3744 3515 -229
Flags with carried forward coverage won't be shown. Click here to find out more. |
I thought this was a feature 🤣 |
|
Added before/after videos. |
surajshetty3416
approved these changes
Apr 7, 2022
|
@Mergifyio backport version-13-hotfix |
✅ Backports have been created
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
Start at the default location
"Fly" to the stored location, if any
Very annoying to see hundreds of "flights" while clicking through multiple records.
Bildschirmaufnahme.2022-04-06.um.13.05.25.mov
Else: try to geolocate the user (See video above)
This causes annoying browser pop-ups on every form load. Also, who says that I want to map something at the user's location?
Shows largely gray tiles
I guess because the size of the control has changed since initialization. To reproduce, add some fields and a collapsible section break.
gray-old.mov
After
Start at the stored location, or, if None, at the default location
Bildschirmaufnahme.2022-04-06.um.13.13.31.mov
Don't proactively try to locate users. Who wants to be located can click the "locate" button. (See video above)
Call
map.invalidateSize()to make leaflet check the current size of the control and adjust accordingly - no more gray tiles!Bildschirmaufnahme.2022-04-06.um.13.30.34.mov