8000 fix(refactor): lockdown frappe.desk.reportview (bp #12713) by mergify[bot] · Pull Request #12731 · frappe/frappe · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(refactor): lockdown frappe.desk.reportview (bp #12713) #12731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Mar 31, 2021
Merged

fix(refactor): lockdown frappe.desk.reportview (bp #12713) #12731

merged 14 commits into from
Mar 31, 2021

Conversation

mergify[bot]
Copy link
Contributor
@mergify mergify bot commented Mar 31, 2021

This is an automatic backport of pull request #12713 done by Mergify.

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.io/

rmehta and others added 14 commits March 31, 2021 05:25
@rmehta
fix(refactor): lockdown frappe.desk.reportview
6ba3a95 
(cherry picked from commit a2ffea5)
@rmehta
fix(minor): fieldnames can't have commas
0fab70f 
(cherry picked from commit 511a5dd)
@rmehta
fix(minor): functions must end with bracket
64f2173 
(cherry picked from commit 0c99594)
@rmehta
fix(minor): handle as fieldnames
5e8cbfa 
(cherry picked from commit 0def975)
@rmehta
fix(minor): make group_by validation tighter
6d2a909 
(cherry picked from commit c9b3679)
@rmehta
fix(report): move count, aggregation to serverside
939b5a9 
(cherry picked from commit 6d978a1)
@rmehta
fix(minor): disallow comments in fields
97a0f6f 
(cherry picked from commit f1f6477)
@rmehta
fix(minor): lockdown frappe.client.get_list
80c2661 
(cherry picked from commit 2248c6c)
@rmehta
fix(minor): tests and linting
8c3debc 
(cherry picked from commit d959fc7)
@rmehta
fix(minor): return value in reportview.py
cf526d7 
(cherry picked from commit 1aa8ada)
@rmehta
fix(minor): tests
2acaf1a 
(cherry picked from commit 868228b)
@rmehta
fix(minor): tests
5a8c89c 
(cherry picked from commit 82399dd)
@rmehta
fix(reportview): test
aa6288a 
(cherry picked from commit 337bdc9)
@rmehta @surajshetty3416
Update frappe/desk/reportview.py
8203ab6 
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
(cherry picked from commit 375cdea)
@mergify mergify bot requested review from a team and surajshetty3416 and removed request for a team March 31, 2021 05:25
@mergify mergify bot mentioned this pull request Mar 31, 2021
Merged
@rmehta rmehta merged commit 6ed664b into version-13-pre-release Mar 31, 2021
@mergify mergify bot deleted the mergify/bp/version-13-pre-release/pr-12713 branch March 31, 2021 05:28
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@surajshetty3416 surajshetty3416 Awaiting requested review from surajshetty3416

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rmehta
0