8000 fix: Reload website_theme_ignore_app before Website Theme by surajshetty3416 · Pull Request #12783 · frappe/frappe · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: Reload website_theme_ignore_app before Website Theme #12783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2021
Merged

fix: Reload website_theme_ignore_app before Website Theme #12783

merged 1 commit into from
Apr 4, 2021

Conversation

surajshetty3416
Copy link
Member
@surajshetty3416 surajshetty3416 commented Apr 2, 2021 •
edited
Loading

should avoid:

File “/home/frappe/frappe-bench/apps/frappe/frappe/commands/init.py”, line 27, in _func
ret = f(frappe._dict(ctx.obj), *args, **kwargs)
File “/home/frappe/frappe-bench/apps/frappe/frappe/commands/site.py”, line 297, in migrate
migrate(
File “/home/frappe/frappe-bench/apps/frappe/frappe/migrate.py”, line 67, in migrate
frappe.modules.patch_handler.run_all(skip_failing)
File “/home/frappe/frappe-bench/apps/frappe/frappe/modules/patch_handler.py”, line 41, in run_all
run_patch(patch)
File “/home/frappe/frappe-bench/apps/frappe/frappe/modules/patch_handler.py”, line 30, in run_patch
if not run_single(patchmodule = patch):
File “/home/frappe/frappe-bench/apps/frappe/frappe/modules/patch_handler.py”, line 71, in run_single
return execute_patch(patchmodule, method, methodargs)
File “/home/frappe/frappe-bench/apps/frappe/frappe/modules/patch_handler.py”, line 91, in execute_patch
frappe.get_attr(patchmodule.split()[0] + “.execute”)()
File “/home/frappe/frappe-bench/apps/frappe/frappe/patches/v13_0/website_theme_custom_scss.py”, line 17, in execu
te
doc.save()
File “/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py”, line 284, in save
return self._save(*args, **kwargs)
File “/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py”, line 319, in _save
self.run_before_save_methods()
File “/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py”, line 949, in run_before_save_methods
self.run_method(“validate”)
File “/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py”, line 847, in run_method
out = Document.hook(fn)(self, *args, **kwargs)
File “/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py”, line 1136, in composer
return composed(self, method, *args, **kwargs)
File “/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py”, line 1119, in runner
add_to_return_value(self, fn(self, *args, **kwargs))
File “/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py”, line 841, in
fn = lambda self, *args, **kwargs: getattr(self, method)(*args, **kwargs)
File “/home/frappe/frappe-bench/apps/frappe/frappe/website/doctype/website_theme/website_theme.py”, line 14, in v
alidate
self.generate_bootstrap_theme()
File “/home/frappe/frappe-bench/apps/frappe/frappe/website/doctype/website_theme/website_theme.py”, line 69, in g
enerate_bootstrap_theme
self.theme_scss = content = get_scss(self)
File “/home/frappe/frappe-bench/apps/frappe/frappe/website/doctype/website_theme/website_theme.py”, line 145, in
get_scss
apps_to_ignore = tuple((d.app + ‘/’) for d in website_theme.ignored_apps)
AttributeError: ‘WebsiteTheme’ object has no attribute 
8000
ignored_apps’

@surajshetty3416 surajshetty3416 mentioned this pull request Apr 2, 2021
Closed
@surajshetty3416
Copy link
Member Author

@Mergifyio backport version-13-pre-release

@surajshetty3416 surajshetty3416 merged commit 778cd75 into frappe:develop Apr 4, 2021
@surajshetty3416 surajshetty3416 deleted the fix-website-theme-patch branch April 4, 2021 04:47
@mergify mergify bot mentioned this pull request Apr 4, 2021
Merged
@mergify
Copy link
Contributor
mergify bot commented Apr 4, 2021

Command backport version-13-pre-release: success

Backports have been created

surajshetty3416 added a commit that referenced this pull request Apr 4, 2021
@surajshetty3416
Merge pull request #12795 from frappe/mergify/bp/version-13-pre-relea…
7fe7206 
…se/pr-12783

fix: Reload website_theme_ignore_app before Website Theme (bp #12783)
@barredterra barredterra linked an issue Apr 5, 2021 that may be closed by this pull request
'WebsiteTheme' object has no attribute 'ignored_apps' #12180
Closed
@barredterra barredterra mentioned this pull request Apr 6, 2021
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'WebsiteTheme' object has no attribute 'ignored_apps'
1 participant
@surajshetty3416
0