8000 fix: oauth code pointing to older desktop page by sagarvora · Pull Request #11483 · frappe/frappe · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: oauth code pointing to older desktop page #11483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 14, 2020
Merged

fix: oauth code pointing to older desktop page #11483

merged 1 commit into from
Sep 14, 2020

Conversation

sagarvora
Copy link
Contributor

Tested on production (google oauth) on branch version-13-beta with new desk page feature.

@sagarvora sagarvora requested review from a team and surajshetty3416 and removed request for a team September 14, 2020 07:59
@scmmishra scmmishra merged commit d618736 into frappe:version-13-beta Sep 14, 2020
@scmmishra
Copy link
Contributor

@Mergifyio backport develop

@mergify
Copy link
Contributor
mergify bot commented Sep 14, 2020

Command backport develop: failure

No backport have been created

  • Backport to branch develop failed

Cherry-pick of e7e3a7a has failed:

On branch mergify/bp/develop/pr-11483
Your branch is up to date with 'origin/develop'.

You are currently cherry-picking commit e7e3a7a6ca.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)

	both modified:   frappe/utils/oauth.py

no changes added to commit (use "git add" and/or "git commit -a")

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@scmmishra scmmishra scmmishra approved these changes

@surajshetty3416 surajshetty3416 Awaiting requested review from surajshetty3416

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sagarvora @scmmishra
0