8000 refactor: Frappe logger by gavindsouza · Pull Request #11026 · frappe/frappe · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: Frappe logger #11026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Aug 3, 2020
Merged

refactor: Frappe logger #11026

merged 15 commits into from
Aug 3, 2020

Conversation

gavindsouza
Copy link
Collaborator
@gavindsouza gavindsouza commented Jul 16, 2020 •
edited
Loading

Changes:

  • Added allow_site parameter in frappe.logger to (dis)allow logging on site-level
  • Added filter paramter in frappe.logger to pass a filter for logging
  • Changed logger name from {module} to {module}-{site-name}
  • Added max_size and file_count parameters for configurable API

Fixes:

  • Issue: Incorrect logging of data under ./sites/{site-name}/logs/frappe.web.log

Docs Link: frappe/frappe_docs#19

@adityahase adityahase self-assigned this Jul 17, 2020
@gavindsouza gavindsouza marked this pull request as ready for review July 17, 2020 06:34
@gavindsouza gavindsouza requested review from a team, Thunderbottom and adityahase and removed request for a team July 17, 2020 06:34
Thunderbottom
Thunderbottom previously requested changes Jul 17, 2020
View reviewed changes
@gavindsouza @Thunderbottom
refactor: less word do trick
c87d598 
Co-authored-by: Chinmay Pai <chinmaydpai@gmail.com>
@gavindsouza gavindsouza force-pushed the site-web-logger-fix branch from 1ec0792 to c87d598 Compare July 17, 2020 12:10
@surajshetty3416 surajshetty3416 added add-description Details or Reason for the change. Also add screenshots and animated GIF if applicable and removed add-description Details or Reason for the change. Also add screenshots and animated GIF if applicable labels Jul 20, 2020
@gavindsouza gavindsouza force-pushed the site-web-logger-fix branch from 2423a22 to ae3ee5b Compare July 29, 2020 08:03
adityahase
adityahase requested changes Jul 29, 2020
View reviewed changes
Copy link
Member
@adityahase adityahase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this documented anywhere?

@gavindsouza
Copy link
Collaborator Author

Is this documented anywhere?

@adityahase I'll update docs once the PR is "ready"

@gavindsouza gavindsouza changed the title fix: Validate site before logging site request data fix: frappe.logger site validation Jul 30, 2020
@gavindsouza
Copy link
Collaborator Author

@Mergifyio backport version-13-beta-pre-release

@mergify
8000
Copy link
Contributor
mergify bot commented Aug 3, 2020

Command backport version-13-beta-pre-release: pending

Waiting for the pull request to get merged

@surajshetty3416
Copy link
Member

@Mergifyio refresh

@mergify
Copy link
Contributor
mergify bot commented Aug 3, 2020

Command refresh: success

@mergify mergify bot merged commit 849804c into frappe:develop Aug 3, 2020
@mergify mergify bot mentioned this pull request Aug 3, 2020
Merged
@mergify
Copy link
Contributor
mergify bot commented Aug 3, 2020 8000

Command backport version-13-beta-pre-release: success

Backports have been created

gavindsouza added a commit that referenced this pull request Aug 3, 2020
@gavindsouza
Merge pull request #11173 from frappe/mergify/bp/version-13-beta-pre-…
4308dba 
…release/pr-11026

fix: frappe.logger site validation (bp #11026)
@centaur78 centaur78 mentioned this pull request Aug 3, 2020
Closed
@gavindsouza gavindsouza changed the title fix: frappe.logger site validation refactor: Frappe logger Aug 4, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adityahase adityahase adityahase approved these changes

@Thunderbottom Thunderbottom Thunderbottom left review comments

Assignees

@adityahase adityahase

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gavindsouza @surajshetty3416 @adityahase @Thunderbottom
0