8000 feat: improve text editor by safwansamsudeen · Pull Request #340 · frappe/frappe-ui · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: improve text editor #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

feat: improve text editor #340

wants to merge 10 commits into from

Conversation

safwansamsudeen
Copy link
Contributor
@safwansamsudeen safwansamsudeen commented Jun 24, 2025 •
edited
Loading

Improvements to text editor based on Drive's needs (most changes relate to the bubble menu).

Changes:

  • Add task list and strikethrough as part of the default commands
  • Submenu:
    • Make styling look more polished (align with Espresso)
    • Allow setting a default label, instead of just the first command
    • Allow for searching
image
  • Allow for the styling of bubble buttons
  • Expose editor in top and bottom slots (currently useless apart from semantics)

Others:

  • Add an xs button size to frappe-ui
  • Add a scroll-shadow class for better UI while scrolling a container.

Should contain no breaking changes.

@safwansamsudeen safwansamsudeen changed the title Improve text editor feat: improve text editor Jun 24, 2025
@safwansamsudeen safwansamsudeen marked this pull request as ready for review June 25, 2025 16:16
safwansamsudeen
safwansamsudeen commented Jun 25, 2025
View reviewed changes
@safwansamsudeen safwansamsudeen mentioned this pull request Jun 25, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@netchampfaris netchampfaris Awaiting requested review from netchampfaris

@surajshetty3416 surajshetty3416 Awaiting requested review from surajshetty3416

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@safwansamsudeen
0