feat: introduce part_group_name and extra flasher fields #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces the new field part_group_name across multiple game item modules and adds extra flasher-related fields as well as an exposure value in gamedata. The key changes include:
- Adding an optional part_group_name field and updating shared attribute trait implementations to accommodate it.
- Adjusting Biff read/write implementations in most game item modules to include the new field.
- Introducing new flasher fields (render_mode, render_style, glass properties, image_src_link, backglass) and an exposure field in gamedata.
Reviewed Changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/vpx/gameitem/* | Added part_group_name field and updated shared attribute logic. |
| src/vpx/gameitem/flasher.rs | Added new rendering and glass-related fields for flasher. |
| src/vpx/gamedata.rs | Introduced new exposure field with corresponding serialization. |
| src/vpx/gameitem/select.rs | Updated shared attribute trait to include part_group_name. |
| src/vpx/gameitem/dragpoint.rs | Modified BiffWrite implementation to a free function. |
| src/vpx/gameitem.rs | Added PartGroup variant and updated GameItemEnum accordingly. |
Comments suppressed due to low confidence (3)
src/vpx/gameitem/dragpoint.rs:203
- [nitpick] Consider renaming the function 'biff_write' to better align with the trait-based BiffWrite implementations in other modules for consistency.
pub(super) fn biff_write(
src/vpx/gameitem/lightsequencer.rs:214
- [nitpick] Ensure that the custom shared attribute serialization in LightSequencer remains consistent with other modules, particularly regarding the ordering when 'part_group_name' is present.
if let Some(editor_layer) = self.editor_layer {
src/vpx/gamedata.rs:1076
- [nitpick] If a default exposure value of 1.0 is intended, consider initializing 'exposure' with 1.0 or documenting that None should be interpreted as 1.0.
exposure: None, // 1.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #135