8000 Defaulted properties should not be injected · Issue #400 · framework-one/fw1 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Defaulted properties should not be injected #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
seancorfield opened this issue Nov 20, 2015 · 2 comments
Closed

Defaulted properties should not be injected #400

seancorfield opened this issue Nov 20, 2015 · 2 comments
Assignees
@seancorfield
Labels
BREAKING enhancement
Milestone
4.0

Comments

@seancorfield
Copy link
Member

Thanks to @mjclemente on the CFML Slack for causing me to observe that a property with a default most likely does not represent a dependency (since dependencies don't have defaults).

Accordingly, I'm going to add omitDefaultedProperties but default it to true in 4.0 (a potentially breaking change). I'm also going to change the default for omitTypedProperties to true for the same reason and for consistency. Also a potentially breaking change (for folks who do not currently use that setting).
@seancorfield seancorfield self-assigned this Nov 20, 2015
@seancorfield seancorfield added this to the 4.0 milestone Nov 20, 2015
seancorfield added a commit that referenced this issue Nov 20, 2015
@seancorfield
Fix #400 by checking defaulted properties
f4a515d 
Change typed property default to ignore (breaking).
Add defaulted property with default to ignore.
Update tests to verify behavior.
@seancorfield
Copy link
Member Author

Needs documenting with a note that this is a breaking change.
8000

seancorfield added a commit that referenced this issue Nov 20, 2015
@seancorfield
ACF compatibility for #400
a9e9dca
@seancorfield
Copy link
Member Author

Soving the BREAKING aspect by adding a changes document for the 4.0 documentation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seancorfield seancorfield

Labels
BREAKING enhancement
Projects
None yet
Milestone
4.0
Development

No branches or pull requests
1 participant
@seancorfield
0