8000 feat: Add builder for Cache to make it easier to discover by Xuanwo · Pull Request #967 · foyer-rs/foyer · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: Add builder for Cache to make it easier to discover #967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 17, 2025
Merged

feat: Add builder for Cache to make it easier to discover #967

merged 3 commits into from
Apr 17, 2025

Conversation

Xuanwo
Copy link
Contributor
@Xuanwo Xuanwo commented Apr 17, 2025

What's changed and what's your intention?

Close #964

Checklist

  • I have written the necessary rustdoc comments
  • I have added the necessary unit tests and integration tests
  • I have passed make all (or make fast instead if the old tests are not modified) in my local environment.

Related issues or PRs (optional)

@Xuanwo
feat: Add builder for Cache to make it easier to discover
bc4c453 
Signed-off-by: Xuanwo <github@xuanwo.io>
MrCroxx
MrCroxx reviewed Apr 17, 2025
View reviewed changes
Copy link
Member
@MrCroxx MrCroxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Xuanwo. Just a small concern.

@codecov Codecov
Copy link
codecov bot commented Apr 17, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
foyer-memory/src/cache.rs 0.00% 3 Missing ⚠️
Files with missing lines Coverage Δ
foyer-memory/src/cache.rs 79.02% <0.00%> (-0.56%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Xuanwo
Tune API
99d74f5 
Signed-off-by: Xuanwo <github@xuanwo.io>
MrCroxx
MrCroxx reviewed Apr 17, 2025
View reviewed changes
@Xuanwo
Remove not needed API
e665489 
Signed-off-by: Xuanwo <github@xuanwo.io>
MrCroxx
MrCroxx approved these changes Apr 17, 2025
View reviewed changes
Copy link
Member
@MrCroxx MrCroxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥰 Thank you for your contribution, Xuanwo.

@MrCroxx MrCroxx merged commit 2ee2e6c into foyer-rs:main Apr 17, 2025
78 of 79 checks passed
@MrCroxx MrCroxx added the feature New feature or request label Apr 17, 2025
@MrCroxx MrCroxx added this to the v0.17 milestone Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrCroxx MrCroxx MrCroxx approved these changes

Assignees
No one assigned
Labels
feature New feature or request
Projects
foyer - Development Roadmap
Status: No status
Milestone
v0.17
Development

Successfully merging this pull request may close these issues.

feat: create cache build with cache type associated function
2 participants
@Xuanwo @MrCroxx
0