8000 feat: support OnDisk cache location advice by MrCroxx · Pull Request #959 · foyer-rs/foyer · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: support OnDisk cache location advice #959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 18, 2025
Merged

feat: support OnDisk cache location advice #959

merged 2 commits into from
Apr 18, 2025

Conversation

MrCroxx
Copy link
Member
@MrCroxx MrCroxx commented Apr 15, 2025

What's changed and what's your intention?

Please explain IN DETAIL what the changes are in this PR and why they are needed. :D

As title.

Checklist

  • I have written the necessary rustdoc comments
  • I have added the necessary unit tests and integration tests
  • I have passed make all (or make fast instead if the old tests are not modified) in my local environment.

Related issues or PRs (optional)

#927 , left discussion: Is it necessary to make popluated entry still follow the cache location advice?
close #928

Signed-off-by: MrCroxx <mrcroxx@outlook.com>
@MrCroxx MrCroxx added the feature New feature or request label Apr 15, 2025
@MrCroxx MrCroxx added this to the v0.17 milestone Apr 15, 2025
@MrCroxx MrCroxx self-assigned this Apr 15, 2025
Copy link
codecov bot commented Apr 15, 2025

Codecov Report

Attention: Patch coverage is 46.98795% with 44 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
foyer-memory/src/cache.rs 8.33% 22 Missing ⚠️
foyer/src/hybrid/cache.rs 51.28% 19 Missing ⚠️
foyer-memory/src/raw.rs 87.50% 2 Missing ⚠️
foyer/src/hybrid/writer.rs 66.66% 1 Missing ⚠️
Files with missing lines Coverage Δ
foyer-common/src/location.rs 100.00% <ø> (ø)
foyer-storage/src/store.rs 80.14% <100.00%> (+0.03%) ⬆️
foyer/src/hybrid/writer.rs 97.05% <66.66%> (-1.45%) ⬇️
foyer-memory/src/raw.rs 89.02% <87.50%> (-0.18%) ⬇️
foyer/src/hybrid/cache.rs 82.70% <51.28%> (-2.60%) ⬇️
foyer-memory/src/cache.rs 76.23% <8.33%> (-3.35%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: MrCroxx <mrcroxx@outlook.com>
@MrCroxx MrCroxx merged commit 82168c1 into main Apr 18, 2025
43 checks passed
@MrCroxx MrCroxx deleted the xx/disk branch April 18, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

feat: disk cache only fetch-like API
1 participant
0