refactor: refine flush on close to mitigate burst #956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
Testcargo build --release && RUST_BACKTRACE=full RUST_LOG=info ./target/release/foyer-bench --file /dev/nvme2n1 --mem 8GiB --disk 1TiB --region-size 64MiB --get-range 1000 --flushers 8 --reclaimers 4 --time 10 --writers 64 --w-rate 64MiB --readers 256 --r-rate 16MiB --metrics --warm-up 2 --runtime separated --user-runtime-worker-threads 8 --read-runtime-worker-threads 8 --write-runtime-worker-threads 4 --engine large --entry-size-min 1KiB --entry-size-max 128KiB --blob-index-size 128KiB --recover-mode none --disk-write-throughput 1GiB --disk-read-iops 1000 --disk-read-throughput 100MiB --flush-on-closeOutput: As expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
The original design cannot handle the burst admission pick on flush.
The new design uses a dedicated io throttle on flush to limit the enqueue rate.
Checklist
make all(ormake fastinstead if the old tests are not modified) in my local environment.Related issues or PRs (optional)
#897 #926