8000 fix: fix panic if buffer_pool_size / flushers is not 4K aligned by MrCroxx · Pull Request #947 · foyer-rs/foyer · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: fix panic if buffer_pool_size / flushers is not 4K aligned #947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2025
Merged

fix: fix panic if buffer_pool_size / flushers is not 4K aligned #947

merged 1 commit into from
Apr 10, 2025

Conversation

MrCroxx
Copy link
Member
@MrCroxx MrCroxx commented Apr 10, 2025

What's changed and what's your intention?

Please explain IN DETAIL what the changes are in this PR and why they are needed. :D

As title.

Checklist

  • I have written the necessary rustdoc comments
  • I have added the necessary unit tests and integration tests
  • I have passed make all (or make fast instead if the old tests are not modified) in my local environment.

Related issues or PRs (optional)

close #945

@MrCroxx
fix: fix panic if buffer_pool_size / flushers is not 4K aligned
303f51f 
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
@MrCroxx MrCroxx added the bug Something isn't working label Apr 10, 2025
@MrCroxx MrCroxx added this to the v0.16 milestone Apr 10, 2025
@MrCroxx MrCroxx self-assigned this Apr 10, 2025
@MrCroxx MrCroxx mentioned this pull request Apr 10, 2025
Closed
@codecov Codecov
Copy link
codecov bot commented Apr 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
foyer-storage/src/large/flusher.rs 83.56% <100.00%> (+0.09%) ⬆️
foyer-storage/src/store.rs 87.37% <100.00%> (+0.40%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@davidhewitt
Copy link

Thanks, can confirm this fixes in my setup 👍

@MrCroxx
Copy link
Member Author
MrCroxx commented Apr 10, 2025

Thanks, can confirm this fixes in my setup 👍

Good to hear it! I'll be AFK for hours. I'll merge it and release a patched version ASAP after I'm available.

@MrCroxx MrCroxx merged commit 685b70c into main Apr 10, 2025
43 checks passed
@MrCroxx MrCroxx deleted the xx/fix-buffer-pool-align branch April 10, 2025 14:56
MrCroxx added a commit that referenced this pull request Apr 10, 2025
@MrCroxx
fix: fix panic if buffer_pool_size / flushers is not 4K aligned (#947)
356f84a 
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
MrCroxx added a commit that referenced this pull request Apr 10, 2025
@MrCroxx
fix: fix panic if buffer_pool_size / flushers is not 4K aligned (#947) (
cce4ce5 
#948)

Signed-off-by: MrCroxx <mrcroxx@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MrCroxx MrCroxx

Labels
bug Something isn't working
Projects
foyer - Development Roadmap
Status: Done
Milestone
v0.16
Development

Successfully merging this pull request may close these issues.

panic when configuring hybrid cache, new in foyer 0.16
2 participants
@MrCroxx @davidhewitt
0