8000 refactor: unify `DeviceStats` and `Statistics` by MrCroxx · Pull Request #937 · foyer-rs/foyer · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: unify DeviceStats and Statistics #937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 8, 2025
Merged

refactor: unify DeviceStats and Statistics #937

merged 2 commits into from
Apr 8, 2025

Conversation

MrCroxx
Copy link
Member
@MrCroxx MrCroxx commented Apr 8, 2025

What's changed and what's your intention?

Please explain IN DETAIL what the changes are in this PR and why they are needed. :D

As title.

Checklist

  • I have written the necessary rustdoc comments
  • I have added the necessary unit tests and integration tests
  • I have passed make all (or make fast instead if the old tests are not modified) in my local environment.

Related issues or PRs (optional)

close #936

@MrCroxx
refactor: unify DeviceStats and Statistics
3229621 
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
@MrCroxx MrCroxx added this to the v0.17 milestone Apr 8, 2025
@MrCroxx MrCroxx self-assigned this Apr 8, 2025
@codecov Codecov
Copy link
codecov bot commented Apr 8, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 82.81250% with 22 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
foyer-storage/src/storage/noop.rs 41.17% 10 Missing ⚠️
foyer-storage/src/large/tombstone.rs 60.00% 4 Missing ⚠️
foyer-storage/src/device/mod.rs 50.00% 3 Missing ⚠️
foyer-storage/src/device/monitor.rs 84.61% 2 Missing ⚠️
foyer-storage/src/engine.rs 83.33% 2 Missing ⚠️
foyer-storage/src/store.rs 87.50% 1 Missing ⚠️
Files with missing lines Coverage Δ
foyer-bench/src/analyze.rs 99.00% <100.00%> (ø)
foyer-bench/src/main.rs 65.10% <100.00%> (-0.13%) ⬇️
foyer-storage/src/large/flusher.rs 83.47% <ø> (-0.23%) ⬇️
foyer-storage/src/large/generic.rs 86.26% <100.00%> (-0.06%) ⬇️
foyer-storage/src/large/reclaimer.rs 86.40% <100.00%> (-0.11%) ⬇️
foyer-storage/src/picker/utils.rs 96.02% <100.00%> (ø)
foyer-storage/src/small/flusher.rs 84.21% <100.00%> (-1.37%) ⬇️
foyer-storage/src/small/generic.rs 75.69% <100.00%> (+0.55%) ⬆️
foyer-storage/src/small/set_manager.rs 87.57% <ø> (-1.70%) ⬇️
foyer-storage/src/statistics.rs 100.00% <100.00%> (+19.35%) ⬆️
... and 8 more

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MrCroxx
fix: fix statistics misbuild
0a2b6e7 
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
@MrCroxx
Copy link
Member Author
MrCroxx commented Apr 8, 2025

And this refactor helps fix statistics bugs.

image

@MrCroxx MrCroxx merged commit 417b7c5 into main Apr 8, 2025
43 checks passed
@MrCroxx MrCroxx deleted the xx/unify-stats branch April 8, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MrCroxx MrCroxx

Labels
refactor
Projects
foyer - Development Roadmap
Status: Done
Milestone
v0.17
Development

Successfully merging this pull request may close these issues.

refactor: unify DeviceStats and Statistics
1 participant
@MrCroxx
0