8000 test: upload binaries when asan/lsan test fails by MrCroxx · Pull Request #335 · foyer-rs/foyer · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

test: upload binaries when asan/lsan test fails #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 14, 2024
Merged

test: upload binaries when asan/lsan test fails #335

merged 3 commits into from
Apr 14, 2024

Conversation

MrCroxx
Copy link
Member
@MrCroxx MrCroxx commented Apr 14, 2024

What's changed and what's your intention?

Please explain IN DETAIL what the changes are in this PR and why they are needed. :D

As title.

Checklist

  • I have written the necessary rustdoc comments
  • I have added the necessary unit tests and integration tests
  • I have passed make all (or make fast instead if the old tests are not modified) in my local environment.

Related issues or PRs (optional)

Signed-off-by: MrCroxx <mrcroxx@outlook.com>
@MrCroxx MrCroxx self-assigned this Apr 14, 2024
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
Copy link
codecov bot commented Apr 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.08%. Comparing base (cb2616e) to head (2a78a85).
Report is 7 commits behind head on main.

❗ Current head 2a78a85 differs from pull request most recent head 339bdb4. Consider uploading reports for the commit 339bdb4 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #335      +/-   ##
==========================================
- Coverage   78.32%   78.08%   -0.25%     
==========================================
  Files          60       60              
  Lines        7623     7680      +57     
==========================================
+ Hits         5971     5997      +26     
- Misses       1652     1683      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: MrCroxx <mrcroxx@outlook.com>
@MrCroxx MrCroxx enabled auto-merge (squash) April 14, 2024 12:32
@MrCroxx MrCroxx merged commit d5c435b into main Apr 14, 2024
@MrCroxx MrCroxx deleted the xx/ci branch April 14, 2024 12:39
MrCroxx added a commit that referenced this pull request Apr 17, 2024
* test: upload binaries when asan/lsan test fails

Signed-off-by: MrCroxx <mrcroxx@outlook.com>

* fix: fix if condition

Signed-off-by: MrCroxx <mrcroxx@outlook.com>

* fix: use different name for different artifacts

Signed-off-by: MrCroxx <mrcroxx@outlook.com>

---------

Signed-off-by: MrCroxx <mrcroxx@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant
0