changed ui.notifications.info to ui.notifications.success in the two … #5609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…places where it completes a process
|
closes #5599 |
krbz999
reviewed
May 4, 2025
module/migration.mjs
Outdated
| @@ -154,7 +154,7 @@ export async function migrateWorld({ bypassVersionCheck=false }={}) { | |||
|
|
|||
| // Set the migration as complete | |||
| game.settings.set("dnd5e", "systemMigrationVersion", game.system.version); | |||
| ui.notifications.info(game.i18n.format("MIGRATION.5eComplete", {version}), {permanent: true}); | |||
| ui.notifications.success(game.i18n.format("MIGRATION.5eComplete", {version}), {permanent: true}); | |||
There was a problem hiding this comment.
May as well move fully to new api:
Suggested change
| ui.notifications.success(game.i18n.format("MIGRATION.5eComplete", {version}), {permanent: true}); | |
| ui.notifications.success("MIGRATION.5eComplete", { format: { version }, permanent: true }); |
JPMeehan
reviewed
May 6, 2025
module/migration.mjs
Outdated
| @@ -154,7 +154,7 @@ export async function migrateWorld({ bypassVersionCheck=false }={}) { | |||
|
|
|||
| // Set the migration as complete | |||
| game.settings.set("dnd5e", "systemMigrationVersion", game.system.version); | |||
| ui.notifications.info(game.i18n.format("MIGRATION.5eComplete", {version}), {permanent: true}); | |||
| ui.notifications.success(game.i18n.format("MIGRATION.5eComplete", { format: { version }, permanent: true })); | |||
There was a problem hiding this comment.
you didn't remove the use of game.i18n.format here
There was a problem hiding this comment.
Thank you for the catch; will address after day job time is done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is clos
303F
ed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed ui.notifications.info to ui.notifications.success in the two places where it completes a process