8000 [#5130] Adjust passive skills based on roll mode by arbron · Pull Request #5452 · foundryvtt/dnd5e · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[#5130] Adjust passive skills based on roll mode #5452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: advantage/abilities
Choose a base branch
from
Open

[#5130] Adjust passive skills based on roll mode #5452

wants to merge 2 commits into from

Conversation

arbron
Copy link
Collaborator
@arbron arbron commented Mar 31, 2025

Increases or decreases passive ability scores by 5 depending on whether the skill has advantage or disadvantage. Adds an option to CONFIG to set this value.

Todo

Closes #5130

@arbron arbron added this to the D&D5E 4.4.0 milestone Mar 31, 2025
@arbron arbron self-assigned this Mar 31, 2025
krbz999
krbz999 reviewed Mar 31, 2025
View reviewed changes
@arbron arbron added system: dice Dice rolling functionality and removed feature request labels Mar 31, 2025
@arbron arbron linked an issue Mar 31, 2025 that may be closed by this pull request
Advantage mode should add +5/-5 to passive scores for skills/tools/etc #5130
Open
@arbron arbron force-pushed the advantage/abilities branch from 8870207 to 292837f Compare April 5, 2025 03:58
@arbron arbron force-pushed the advantage/passive branch from cb28cd3 to 3280173 Compare April 5, 2025 03:59
@arbron arbron removed this from the D&D5E 4.4.0 milestone Apr 16, 2025
@arbron arbron force-pushed the advantage/abilities branch 2 times, most recently from a5a9e24 to f7e2d54 Compare May 5, 2025 21:35
@arbron arbron force-pushed the advantage/passive branch from 3280173 to 0a71c6d Compare May 5, 2025 22:03
@arbron arbron force-pushed the advantage/abilities branch from f7e2d54 to f1ca308 Compare May 30, 2025 17:11
arbron added 2 commits May 30, 2025 10:11
@arbron
[#5130] Adjust passive skills based on roll mode
28f0897 
Increases or decreases passive ability scores by `5` depending on
whether the skill has advantage or disadvantage. Adds an option to
`CONFIG` to set this value.

Closes #5130
@arbron
[#5130] Allow skill passive base to also be configurable
1c22790
@arbron arbron force-pushed the advantage/passive branch from 0a71c6d to 1c22790 Compare May 30, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krbz999 krbz999 krbz999 left review comments

Assignees

@arbron arbron

Labels
system: dice Dice rolling functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Advantage mode should add +5/-5 to passive scores for skills/tools/etc
2 participants
@arbron @krbz999
0