8000 Fix unhandled error branch by awvwgk · Pull Request #849 · fortran-lang/fpm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix unhandled error branch #849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2023
Merged

Conversation

awvwgk
Copy link
Member
@awvwgk awvwgk commented Mar 3, 2023

Since toml-f/toml-f#123 the get_value interface of TOML Fortran will properly return an error if a value is not present. The get_list implementation relied on this bug and used the allocation status of the deferred length character variable to catch this case. This patch corrects the behavior on the fpm side and allows to upgrade to future versions of TOML Fortran.

@awvwgk awvwgk added the bug Something isn't working label Mar 3, 2023
@awvwgk awvwgk requested a review from minhqdao March 3, 2023 22:17
Copy link
Contributor
@minhqdao minhqdao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I tried it out with the newest toml-f version and the errors are indeed gone. 🙏🏽

@awvwgk awvwgk merged commit b364bd8 into fortran-lang:main Mar 3, 2023
@awvwgk awvwgk deleted the toml-get-list branch March 3, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0