Allow extra section in package manifest #533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Milan Curcic <caomaco@gmail.com>
everythingfunctional
approved these changes
Aug 5, 2021
|
Is it possible to add a trivial example to the manifest-reference.md file?
I do not mean to encourage people to use this section when it is not
strictly needed, but it might help organise their (or my :)) thoughts about
its actual use.
Op do 5 aug. 2021 om 02:37 schreef Brad Richardson ***@***.***
…:
***@***.**** approved this pull request.
Seems reasonable to me. I'll be curious to see what people do with it.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#533 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAN6YR7WZWRFLFGXKPKI34TT3HMK7ANCNFSM5BRVRI6Q>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>
.
|
|
I was thinking about having an example, but I don't want to raise the expectation that some tool actually supports this already. So here is a hypothetical table for the [extra.findent]
start-indent = 0 # <n>: starting indent (default: 0)
indent = 4 # <n>: all indents (default: 3)
indent-associate = 4 # <n>: ASSOCIATE indent (default: all)
indent-block = 4 # <n>: BLOCK indent (default: all)
indent-do = 4 # <n>: DO indent (default: all)
indent-if = 4 # <n>: IF indent (default: all)
indent-enum = 4 # <n>: ENUM indent (default: all)
indent-forall = 4 # <n>: FORALL indent (default: all)
indent-interface = 4 # <n>: INTERFACE indent (default: all)
indent-module = 4 # <n>: MODULE indent (default: all)
indent-procedure = 4 # <n>: FUNCTION, SUBROUTINE and PROGRAM indent (default: all)
indent-select = 4 # <n>: SELECT indent (default: all)
indent-type = 4 # <n>: TYPE indent (default: all)
indent-where = 4 # <n>: WHERE indent (default: all)
indent-critical = 4 # <n>: CRITICAL indent (default: all)
indent-changeteam = 4 # <n>: CHANGE TEAM indent (default(all)
indent-continuation = 4 # <n>: continuation indent except for lines starting with '&' free to free only
indent-case = -2 # <n>: CASE indent (default: -all/2)
indent-contains = -2 # <n>: CONTAINS indent (default: -all/2)
indent-entry = -2 # <n>: ENTRY indent (default: -all/2)Or a hypothetical configuration for fpm-search adding registries for the current project [extra.fpm.search]
label1 = "https://my-alternate-registry/index.json"
label2 = "https://other-registry/index.json" |
|
Okay, thanks - when it is clearly documented that it is simply an example
for some hypothetical package/tool/..., it should not raise expectations
beyond the possibility that it may be useful for some actual
package/tool/... But the examples you give are useful in my opinion.
Op do 5 aug. 2021 om 09:52 schreef Sebastian Ehlert <
***@***.***>:
… I was thinking about having an example, but I don't want to raise the
expectation that some tool actually supports this already.
So here is a hypothetical table for the findent
<https://sourceforge.net/projects/findent/> tool:
[extra.findent]start-indent = 0 # <n>: starting indent (default: 0) indent = 4 # <n>: all indents (default: 3)indent-associate = 4 # <n>: ASSOCIATE indent (default: all)indent-block = 4 # <n>: BLOCK indent (default: all)indent-do = 4 # <n>: DO indent (default: all)indent-if = 4 # <n>: IF indent (default: all)indent-enum = 4 # <n>: ENUM indent (default: all)indent-forall = 4 # <n>: FORALL indent (default: all)indent-interface = 4 # <n>: INTERFACE indent (default: all)indent-module = 4 # <n>: MODULE indent (default: all)indent-procedure = 4 # <n>: FUNCTION, SUBROUTINE and PROGRAM indent (default: all)indent-select = 4 # <n>: SELECT indent (default: all)indent-type = 4 # <n>: TYPE indent (default: all)indent-where = 4 # <n>: WHERE indent (default: all)indent-critical = 4 # <n>: CRITICAL indent (default: all)indent-changeteam = 4 # <n>: CHANGE TEAM indent (default(all)indent-continuation = 4 # <n>: continuation indent except for lines starting with '&' free to free onlyindent-case = -2 # <n>: CASE indent (default: -all/2)indent-contains = -2 # <n>: CONTAINS indent (default: -all/2)indent-entry = -2 # <n>: ENTRY indent (default: -all/2)
Or a hypothetical configuration for fpm-search
<https://github.com/brocolis/fpm-search> adding registries for the
current project
[extra.fpm.search]label1 = "https://my-alternate-registry/index.json"label2 = "https://other-registry/index.json"
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#533 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAN6YRYUDOKURRESJZGSAFLT3I7NLANCNFSM5BRVRI6Q>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>
.
|
|
Thanks Sebastian @awvwgk, LGTM 👍 With two approvals and myself, I'll now merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #430