8000 Use different compiler flags on different platforms for Intel by everythingfunctional · Pull Request #431 · fortran-lang/fpm · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use different compiler flags on different platforms for Intel #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2021
Merged

Use different compiler flags on different platforms for Intel #431

merged 1 commit into from
Apr 9, 2021

Conversation

everythingfunctional
Copy link
Member

I've tested both profiles (debug and release) on each platform (Windows, MacOS, and Linux) for both Intel compilers (ifort and ifx) and none of them report an problems with flags now.

Note that ifx is not available on MacOS currently, so that is not included in the set of available compilers.

Also Note: none of the Intel compilers were able to compile fpm. ifort gives the following error on all three platforms:

./src/fpm/manifest/build.f90: error #6405: The same named entity from different modules and/or program units cannot be referenced.   [TOML_TABLE]

ifx hits an ICE on Windows, and gives the following error on Linux:

build/dependencies/M_CLI2/src/M_CLI2.f90(1322): error #5533: Feature found on this line is not yet supported in ifx 
            args=[character(len=imax) :: args,current_argument]
----------------------------------------------^

but those are issues for another day.

LKedward
LKedward approved these changes Apr 8, 2021
View reviewed changes
Copy link
Member
@LKedward LKedward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

urbanjost
urbanjost approved these changes Apr 9, 2021
View reviewed changes
Copy link
Contributor
@urbanjost urbanjost left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recently changed hardware and could not test all the combinations. I thought other issues would arise with loading and library names after the compile but what I could test had no issues. Either way these compiler flags needed changed and It worked on my laptop. Another step forward.
Thanks. I approve.

@everythingfunctional
Copy link
Member Author

Thanks for the review guys.

@everythingfunctional everythingfunctional merged commit 6652c86 into fortran-lang:master Apr 9, 2021
@everythingfunctional everythingfunctional mentioned this pull request Apr 9, 2021
Closed
@LKedward LKedward mentioned this pull request Apr 10, 2021
Merged
@LKedward LKedward mentioned this pull request Jun 23, 2021
Merged
@everythingfunctional everythingfunctional deleted the fix-intel-on-windows branch November 3, 2021 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LKedward LKedward LKedward approved these changes

@urbanjost urbanjost urbanjost approved these changes

@awvwgk awvwgk Awaiting requested review from awvwgk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@everythingfunctional @LKedward @urbanjost
0