8000 improve syntax in code and comments by using jargonLint by ccoVeille · Pull Request #944 · fortio/fortio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

improve syntax in code and comments by using jargonLint #944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement< 8000 /a>. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 30, 2024
Merged

improve syntax in code and comments by using jargonLint #944

merged 2 commits into from
Jun 30, 2024

Conversation

ccoVeille
Copy link
Contributor
@ccoVeille ccoVeille commented Jun 29, 2024 •
edited
Loading
  • chore: fix acronyms, typos and style
  • chore: fix acronym in fortio --help

I used my own project to spot the changes

https://github.com/jargonLint/jargonLint

Replace

@ldemailly
Copy link
Member

Merci! repeating here

is the README change from

release/bumpRelease.sh 1.65.0 -f

(it should)

ccoVeille added 2 commits June 30, 2024 01:43
@ccoVeille
fix typos, style and acronyms in code comments
c4ec5cd 
This commit changes only the comments, not the code.

We could change in another PR, the changes are ready in local.
But I wanted to keep them separated.
@ccoVeille
chore: fix acronym in fortio --help
e0a5419
@ldemailly
Copy link
Member

Thanks! Awesome ! can you link your tool in the description of this MR so there is a trace

ldemailly
ldemailly approved these changes Jun 29, 2024
View reviewed changes
Copy link
Member
@ldemailly ldemailly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Awesome ! can you link your tool in the description of this MR so there is a trace

@ccoVeille
Copy link
Contributor Author

https://github.com/jargonLint/jargonLint

@ccoVeille
Copy link
Contributor Author

Feel free to merge whenever you want.

Even if you somehow gave me the right to do it, I would prefer let you do it.

@ldemailly ldemailly merged commit 51b6f9b into master Jun 30, 2024
6 checks passed
@ldemailly ldemailly deleted the improve-syntax branch June 30, 2024 13:58
@ccoVeille ccoVeille changed the title improve syntax improve syntax in code and comments by using jargonLint Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldemailly ldemailly ldemailly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ccoVeille @ldemailly
0