Avoid warmup grpc connection multiple times #926

ktalg · 2024-05-30T03:06:35Z

Currently, each new grpc connection is used to send multiple warmup requests (when grpc-stream>0), which is unexpected, especially for scenarios where the server takes a long time to process, and the whole warmup process will consume a lot of time.

ldemailly · 2024-05-30T19:44:57Z

Thanks - I find it surprising that warming only the first stream of each multiplexed connections makes a difference, specially with the ping 8000 server itself, is that what you see?

ldemailly · 2024-05-30T19:52:23Z

can you add also the nolint so gocyclo / ci passes?

ktalg · 2024-05-31T08:34:12Z

Thanks - I find it surprising that warming only the first stream of each multiplexed connections makes a difference, specially with the ping server itself, is that what you see?

In a testing scenario where the client and server are far apart, each request takes 50ms to reach its destination. When conducting the test: fortio load -grpc -ping -c=10 -s=100 -qps=0 -H="host: server" -gomaxprocs=2 -t=30s <server addr>, fortio requires 10x100x50=50000ms=50s for warmup! This time cost is even greater than the duration of the test itself, which seems unreasonable. I believe that warming up each connection only once should suffice, as this would not cause any adverse effects.

ldemailly

Thanks !

Avoid warmup grpc connection multiple times

9540418

ktalg requested a review from ldemailly May 30, 2024 03:11

fix lint

7ce8d75

ldemailly approved these changes May 31, 2024

View reviewed changes

ldemailly merged commit 854b9ce into fortio:master May 31, 2024
7 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Avoid warmup grpc connection multiple times #926

Avoid warmup grpc connection multiple times #926

Avoid warmup grpc connection multiple times #926

Avoid warmup grpc connection multiple times #926

Conversation

Choose a reason for hiding this comment