8000 go1.19.7 + codeOK fix + streaming misses by ldemailly · Pull Request #727 · fortio/fortio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

go1.19.7 + codeOK fix + streaming misses #727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

< 8000 p class="mt-4 color-fg-muted text-center"> Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 9, 2023
Merged

go1.19.7 + codeOK fix + streaming misses #727

merged 2 commits into from
Mar 9, 2023

Conversation

ldemailly
Copy link
Member
@ldemailly ldemailly commented Mar 9, 2023 •
edited
Loading
  • new go version
  • refactor of client api usage from always returning the bytes to streaming data had 2 misses, including critical one in Run()
  • code to tell access logger success/failure was hardcoded to 200s only instead of using same range as elsewhere

@ldemailly ldemailly requested a review from bseenu March 9, 2023 01:01
@codecov
Copy link
8000
codecov bot commented Mar 9, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.0% and no project coverage change

Comparison is base (6d264d8) 89.7% compared to head (47244a0) 89.7%.

Additional details and impacted files 
@@           Coverage Diff            @@
##           master    #727     +/-   ##
========================================
- Coverage    89.7%   89.7%   -0.0%     
========================================
  Files          16      16             
  Lines        4004    4001      -3     
========================================
- Hits         3593    3590      -3     
  Misses        262     262             
  Partials      149     149
Impacted Files Coverage Δ
fhttp/httprunner.go 91.9% <100.0%> (-0.2%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ldemailly ldemailly mentioned this pull request Mar 9, 2023
Closed
@ldemailly ldemailly changed the title go1.19.7 go1.19.7 + codeOK fix + streaming misses Mar 9, 2023
@ldemailly ldemailly merged commit 365da92 into master Mar 9, 2023
@ldemailly ldemailly deleted the go_1_19_7 branch March 9, 2023 01:29
@ldemailly ldemailly restored the go_1_19_7 branch March 9, 2023 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bseenu bseenu bseenu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ldemailly @bseenu
0