Fix support for adding social image to the Pages API #20916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uffizzi Ephemeral Environment Deploying☁️ https://app.uffizzi.com/github.com/forem/forem/pull/20916 ⚙️ Updating now by workflow run 8937638497. What is Uffizzi? Learn more! |
maestromac
reviewed
May 2, 2024
maestromac
approved these changes
May 3, 2024
| @@ -39,8 +39,11 @@ def require_admin | |||
| end | |||
|
|
|||
| def permitted_params | |||
| if params[:social_image].present? && params[:social_image][:url].present? | |||
There was a problem hiding this comment.
non-blocking nit: there's a nice dig method for this.
Suggested change
| if params[:social_image].present? && params[:social_image][:url].present? | |
| if params.dig(:social_image, :url).present? |
benhalpern
approved these changes
May 6, 2024
There was a problem hiding this comment.
Looks good.
I have some confusion on whether simply setting a param of remote_social_image_url works vs having to call the method as a setter, but I think the tests seem to show this works.
And if there's still a small additional change to be made we can do as a follow-up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This fixes support for specifying the
social_imagefor Pages via the API. The docs don't specify a format for the URL, I've used the same format as the GET route... social_image: { url: "https://blah.png" }.Added/updated tests?
We encourage you to keep the code coverage percentage at 80% and above.