8000 Fix choices crash by travist · Pull Request #125 · formio/formio.js · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix choices crash #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 30, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file
The format is based on [Keep a Changelog](http://keepachangelog.com/)
and this project adheres to [Semantic Versioning](http://semver.org/).

## 2.11.8
### Fixed
- Issue where choices.js changed internal api that we rely on.

## 2.11.7
### Added
- Description support for fields.
Expand Down
12 changes: 6 additions & 6 deletions dist/formio.embed.js

Large diffs are not rendered by default.

30 changes: 15 additions & 15 deletions dist/formio.embed.min.js

Large diffs are not rendered by default.

12 changes: 6 additions & 6 deletions dist/formio.form.js

Large diffs are not rendered by default.

28 changes: 14 additions & 14 deletions dist/formio.form.min.js

Large diffs are not rendered by default.

12 changes: 6 additions & 6 deletions dist/formio.full.js

Large diffs are not rendered by default.

30 changes: 15 additions & 15 deletions dist/formio.full.min.js

Large diffs are not rendered by default.

12 changes: 6 additions & 6 deletions dist/formio.wizard.js

Large diffs are not rendered by default.

30 changes: 15 additions & 15 deletions dist/formio.wizard.min.js

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "formiojs",
"version": "2.11.7",
"version": "2.11.8",
"description": "Common js library for client side interaction with <form.io>",
"main": "build/formio.js",
"files": [
Expand Down Expand Up @@ -47,7 +47,7 @@
},
"homepage": "https://github.com/formio/formio.js#readme",
"dependencies": {
"choices.js": "^2.8.4",
"choices.js": "^2.8.6",
"eventemitter2": "^2.2.2",
"flatpickr": "^3.0.5-1",
"handlebars": "^4.0.10",
Expand Down
4 changes: 2 additions & 2 deletions src/components/select/Select.js
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export class SelectComponent extends BaseComponent {
_each(items, (item) => {

// Add the choice to the select list.
this.choices._addChoice(false, false, this.itemValue(item), this.itemTemplate(item));
this.choices._addChoice(this.itemValue(item), this.itemTemplate(item));
});

// If a value is provided, then select it.
Expand Down Expand Up @@ -193,7 +193,7 @@ export class SelectComponent extends BaseComponent {

// If it is not found, then add it.
if (!foundChoice) {
this.choices._addChoice(false, false, this.itemValue(value), this.itemTemplate(value));
this.choices._addChoice(this.itemValue(value), this.itemTemplate(value));
}
}

Expand Down
0