-
Notifications
You must be signed in to change notification settings - Fork 1.9k
chore: remove unused cache files #5700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for following the naming conventions for pull request titles! 🙏 |
## Walkthrough
This change removes multiple files related to document and insight data management and validation. Specifically, it deletes cache management utilities for documents and insights (`apps/web/lib/cache/document.ts` and `apps/web/lib/cache/insight.ts`), which included methods for generating cache tags and triggering selective cache revalidation. It also removes Zod schemas and TypeScript types for insights (`packages/database/zod/insights.ts`), document-insight relationships (`packages/types/document-insights.ts`), and comprehensive document-related schemas and types including sentiments, creation inputs, filters, and generated insights (`packages/types/documents.ts`). All associated exports and interfaces from these files are removed.
## Suggested reviewers
- pandeymangg 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
💤 Files with no reviewable changes (3)
⏰ Context from checks skipped due to timeout of 90000ms (7)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
This pull request removes the caching logic for documents and insights in the
apps/web
directory. The changes eliminate the ability to generate cache tags and revalidate cache entries for these entities.Removal of caching logic:
apps/web/lib/cache/document.ts
: Removed thedocumentCache
object, which included methods for generating cache tags (e.g.,byId
,bySurveyId
) and arevalidate
function to refresh cache entries for documents.apps/web/lib/cache/insight.ts
: Removed theinsightCache
object, which included methods for generating cache tags (e.g.,byId
,byEnvironmentId
) and arevalidate
function to refresh cache entries for insights.Summary by CodeRabbit