10000 chore: remove unused code by jobenjada · Pull Request #5697 · formbricks/formbricks · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: remove unused code #5697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 7, 2025
Merged

chore: remove unused code #5697

merged 5 commits into from
May 7, 2025

Conversation

jobenjada
Copy link
Member
@jobenjada jobenjada commented May 7, 2025 •
edited by coderabbitai bot
Loading

chore: remove unused UI modules

Summary by CodeRabbit

  • Refactor
    • Removed various UI components including responsive video embeds, separators, slide-in sheet modals, simple layout wrappers, tabbed navigation, textareas, toggle groups and buttons, upgrade plan notices, badge-style dropdown selectors, breadcrumb navigation, and pagination controls.

End-users may notice the absence of embedded videos, modal panels, tabbed views, toggle controls, upgrade alerts, badge selectors, breadcrumb trails, and pagination features.

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented May 7, 2025 •
edited
Loading

Thank you for following the naming conventions for pull request titles! 🙏

@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented May 7, 2025 •
edited
Loading

Walkthrough

This change removes multiple UI component modules from the codebase, specifically within the apps/web/modules/ui/components directory. The deleted components include implementations for responsive video embedding, separators, sheet modals, simple layout wrappers, tabbed interfaces, styled textareas, toggle groups (and their toggle button variants), an upgrade plan notice alert, badge-select dropdowns, breadcrumb navigation, and pagination controls. All associated TypeScript interfaces, props, styling configurations, and Storybook stories for these components have also been deleted. The removals encompass both the component logic and their exported entities, effectively eliminating these UI building blocks from the project.

Additionally, several utility and library files related to authentication checks, caching mechanisms for documents and insights, internationalization string translation, integration and survey access authorization, and HTTP fetching have been deleted from the apps/web/lib directory. These include functions for permission checks on action classes, integrations, surveys, responses, response notes, tags, and tag-on-response entities, as well as cache tag generation and revalidation utilities for documents and insights. The removal of these files deletes all their exported functions, interfaces, and objects, thereby removing related authorization logic, cache management utilities, and fetch utilities from the codebase.

Furthermore, some survey-related library functions for environment retrieval, membership role fetching, and organization ID lookup by environment ID have been deleted, removing their associated caching and error handling logic. A React (Preact) component for redirect countdown has also been removed. Overall, this change results in the deletion of a large set of UI components, utility functions, authorization checks, caching utilities, and related exports from the project.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 91d012b and 033a990.

📒 Files selected for processing (13)
  • apps/web/lib/fetcher.ts (0 hunks)
  • apps/web/lib/response/auth.ts (0 hunks)
  • apps/web/lib/responseNote/auth.ts (0 hunks)
  • apps/web/lib/tag/auth.ts (0 hunks)
  • apps/web/lib/tagOnResponse/auth.ts (0 hunks)
  • apps/web/modules/survey/lib/environment.ts (0 hunks)
  • apps/web/modules/survey/lib/membership.ts (0 hunks)
  • apps/web/modules/survey/list/lib/organization.ts (0 hunks)
  • apps/web/modules/ui/components/badge-select/index.tsx (0 hunks)
  • apps/web/modules/ui/components/badge-select/stories.ts (0 hunks)
  • apps/web/modules/ui/components/breadcrumb/index.tsx (0 hunks)
  • apps/web/modules/ui/components/pagination/index.tsx (0 hunks)
  • packages/surveys/src/components/general/redirect-countdown.tsx (0 hunks)
💤 Files with no reviewable changes (13)
  • apps/web/modules/survey/lib/membership.ts
  • apps/web/modules/survey/list/lib/organization.ts
  • apps/web/lib/tag/auth.ts
  • apps/web/lib/tagOnResponse/auth.ts
  • apps/web/modules/ui/components/badge-select/stories.ts
  • apps/web/lib/fetcher.ts
  • apps/web/modules/survey/lib/environment.ts
  • apps/web/lib/responseNote/auth.ts
  • apps/web/modules/ui/components/pagination/index.tsx
  • packages/surveys/src/components/general/redirect-countdown.tsx
  • apps/web/modules/ui/components/breadcrumb/index.tsx
  • apps/web/lib/response/auth.ts
  • apps/web/modules/ui/components/badge-select/index.tsx
⏰ Context from checks skipped due to timeout of 90000ms (7)
  • GitHub Check: Run E2E Tests / Run E2E Tests
  • GitHub Check: Run Unit Tests / Unit Tests
  • GitHub Check: Run Linters / Linters
  • GitHub Check: Build Formbricks-web / Build Formbricks-web
  • GitHub Check: SonarQube
  • GitHub Check: Validate Docker Build
  • GitHub Check: Analyze (javascript)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jobenjada jobenjada changed the title chore: remove unused UI modules chore: remove unused code May 7, 2025
@mattinannt mattinannt added this pull request to the merge queue May 7, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 7, 2025
@jobenjada jobenjada added this pull request to the merge queue May 7, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 7, 2025
@jobenjada jobenjada enabled auto-merge May 7, 2025 14:00
@sonarqubecloud SonarQubeCloud
Copy link
sonarqubecloud bot commented May 7, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@jobenjada jobenjada added this pull request to the merge queue May 7, 2025
Merged via the queue into main with commit f0be6de May 7, 2025
17 checks passed
@jobenjada jobenjada deleted the remove-unused-code branch May 7, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattinannt mattinannt mattinannt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jobenjada @mattinannt
0