8000 chore: update zod dependency, remove unused labeler action by mattinannt · Pull Request #5678 · formbricks/formbricks · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: update zod dependency, remove unused labeler action #5678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on Git 8000 Hub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2025

Conversation

mattinannt
Copy link
Member
@mattinannt mattinannt commented May 6, 2025

This pull request includes the removal of the pull request labeler workflow and multiple dependency updates across various packages to ensure compatibility and maintainability. Below is a summary of the most important changes grouped by theme:

Workflow Removal:

  • Removed the .github/workflows/labeler.yml file, effectively disabling the pull request labeler workflow. This includes the removal of all associated job configurations, permissions, and steps.

Dependency Updates:

Core Dependency Updates:

  • Updated zod to version 3.24.4 across multiple packages (apps/web, packages/database, packages/logger, packages/types). [1] [2] [3] [4]
  • Updated @types/react to version 19.1.3 in packages/config-typescript and packages/surveys. [1] [2]

Linter and TypeScript Configuration Updates:

  • Updated ESLint-related dependencies in packages/config-eslint, including @next/eslint-plugin-next, @typescript-eslint/eslint-plugin, @typescript-eslint/parser, eslint-config-next, eslint-config-prettier, eslint-config-turbo, and eslint-plugin-react-refresh.
  • Updated @types/node to version 22.15.12 in packages/config-typescript.

Miscellaneous Dependency Updates:

  • Updated @calcom/embed-snippet to version 1.3.3 and isomorphic-dompurify to version 2.24.0 in packages/surveys.
  • Updated prisma-json-types-generator to version 3.3.1 in packages/database.

Summary by CodeRabbit

  • Chores
    • Updated multiple dependencies and development dependencies to their latest patch versions across several packages for improved stability and compatibility.
    • Removed the automated pull request labeling workflow from the repository.

@mattinannt mattinannt requested a review from Copilot May 6, 2025 16:01
Copy link
Contributor
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 9 changed files in this pull request and generated no comments.

Files not reviewed (8)
  • .github/workflows/labeler.yml: Language not supported
  • apps/web/package.json: Language not supported
  • packages/config-eslint/package.json: Language not supported
  • packages/config-typescript/package.json: Language not supported
  • packages/database/package.json: Language not supported
  • packages/logger/package.json: Language not supported
  • packages/surveys/package.json: Language not supported
  • packages/types/package.json: Language not supported

Copy link
Contributor
github-actions bot commented May 6, 2025

Thank you for following the naming conventions for pull request titles! 🙏

Copy link
Contributor
coderabbitai bot commented May 6, 2025

Walkthrough

This change deletes the .github/workflows/labeler.yml file, which previously automated pull request labeling using GitHub Actions. Additionally, it updates dependency versions in several package.json files across multiple packages. Notable updates include bumping the zod package to version 3.24.4 in several locations, upgrading ESLint-related development dependencies in packages/config-eslint, updating TypeScript type definitions in packages/config-typescript and packages/surveys, and adjusting dependency versioning for pino and pino-pretty in packages/logger. No changes were made to exported or public entities.

Possibly related PRs

Suggested reviewers

  • pandeymangg

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor
@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
packages/logger/package.json (1)

38-40: Pin exact dependency versions for reproducible builds
Locking down zod, pino, and pino-pretty to exact versions ensures consistency across environments and matches the coordinated update strategy in this monorepo.
Consider whether this aligns with your patch‐release policy; if you prefer automatic patch updates (e.g., for urgent security fixes), switching to caret ranges (e.g., ^9.6.0) might be more appropriate.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5d45de6 and 6576357.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (8)
  • .github/workflows/labeler.yml (0 hunks)
  • apps/web/package.json (1 hunks)
  • packages/config-eslint/package.json (1 hunks)
  • packages/config-typescript/package.json (1 hunks)
  • packages/database/package.json (1 hunks)
  • packages/logger/package.json (1 hunks)
  • packages/surveys/package.json (1 hunks)
  • packages/types/package.json (1 hunks)
💤 Files with no reviewable changes (1)
  • .github/workflows/labeler.yml
⏰ Context from checks skipped due to timeout of 90000ms (7)
  • GitHub Check: Run Linters / Linters
  • GitHub Check: Build Formbricks-web / Build Formbricks-web
  • GitHub Check: Run E2E Tests / Run E2E Tests
  • GitHub Check: Run Unit Tests / Unit Tests
  • GitHub Check: SonarQube
  • GitHub Check: Validate Docker Build
  • GitHub Check: Analyze (javascript)
🔇 Additional comments (9)
packages/config-eslint/package.json (3)

6-8: Upgrade ESLint Next.js and TypeScript ESLint plugins
The devDependencies for @next/eslint-plugin-next, @typescript-eslint/eslint-plugin, and @typescript-eslint/parser have been bumped to their latest patch versions. These are backward-compatible patch updates and should integrate smoothly.


10-12: Upgrade ESLint configuration packages
The eslint-config-next, eslint-config-prettier, and eslint-config-turbo entries have been patched to newer minor versions. These are safe, non-breaking updates that align with the rest of your linting tooling.


16-17: Upgrade React Refresh and Vitest ESLint plugins
The eslint-plugin-react-refresh and @vitest/eslint-plugin have been bumped to patch releases. No additional config changes appear necessary.

apps/web/package.json (1)

140-140: Verify zod version upgrade consistency
Ensure that bumping "zod" to 3.24.4 is compatible with your existing schemas and that the lockfile reflects this change. Run your full test suite (unit, integration, and type checks) to catch any potential breaking changes.

packages/database/package.json (2)

37-37: Confirm prisma-json-types-generator upgrade
You’ve updated "prisma-json-types-generator" from 3.2.3 to 3.3.1. Verify that this new version generates the expected types and that your migration and data-migration scripts still function correctly. Run the relevant Prisma scripts and compile steps to ensure nothing breaks.


39-39: Align zod version with other packages
Upgrading "zod" to 3.24.4 should stay in sync with the versions in other workspaces. Ensure that schema validations and any OpenAPI generation based on Zod still work as intended by executing your validation tests and builds.

packages/config-typescript/package.json (1)

10-11: Ensure TypeScript definitions compatibility
You bumped @types/node to 22.15.12 and @types/react to 19.1.3. Please run a clean install followed by a full TypeScript build and lint pass to confirm there are no new type errors or mismatches introduced by these updates.

packages/surveys/package.json (1)

41-51: Validate dev dependency bumps
Minor patch upgrades to @calcom/embed-snippet (1.3.3), @types/react (19.1.3), and isomorphic-dompurify (2.24.0) are low risk but verify that survey embedding, sanitization, and any React typings continue to work without regressions. Run your survey-related unit and integration tests.

packages/types/package.json (1)

11-14: Review dependencies section reordering and zod bump
You moved the dependencies block and upgraded zod to 3.24.4 here. Confirm that the reordering doesn’t affect any build scripts or tooling, and that the new zod version is compatible by running your type-checking, build, and validation workflows.

Copy link
sonarqubecloud bot commented May 6, 2025
8000

@mattinannt mattinannt merged commit d67d62d into main May 6, 2025
20 of 21 checks passed
@mattinannt mattinannt deleted the feautre/upgrade-zod-deps branch May 6, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0