-
Notifications
You must be signed in to change notification settings - Fork 1.9k
chore: update zod dependency, remove unused labeler action #5678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on Git 8000 Hub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 9 changed files in this pull request and generated no comments.
Files not reviewed (8)
- .github/workflows/labeler.yml: Language not supported
- apps/web/package.json: Language not supported
- packages/config-eslint/package.json: Language not supported
- packages/config-typescript/package.json: Language not supported
- packages/database/package.json: Language not supported
- packages/logger/package.json: Language not supported
- packages/surveys/package.json: Language not supported
- packages/types/package.json: Language not supported
Thank you for following the naming conventions for pull request titles! 🙏 |
WalkthroughThis change deletes the Possibly related PRs
Suggested reviewers
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/logger/package.json (1)
38-40
: Pin exact dependency versions for reproducible builds
Locking downzod
,pino
, andpino-pretty
to exact versions ensures consistency across environments and matches the coordinated update strategy in this monorepo.
Consider whether this aligns with your patch‐release policy; if you prefer automatic patch updates (e.g., for urgent security fixes), switching to caret ranges (e.g.,^9.6.0
) might be more appropriate.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (8)
.github/workflows/labeler.yml
(0 hunks)apps/web/package.json
(1 hunks)packages/config-eslint/package.json
(1 hunks)packages/config-typescript/package.json
(1 hunks)packages/database/package.json
(1 hunks)packages/logger/package.json
(1 hunks)packages/surveys/package.json
(1 hunks)packages/types/package.json
(1 hunks)
💤 Files with no reviewable changes (1)
- .github/workflows/labeler.yml
⏰ Context from checks skipped due to timeout of 90000ms (7)
- GitHub Check: Run Linters / Linters
- GitHub Check: Build Formbricks-web / Build Formbricks-web
- GitHub Check: Run E2E Tests / Run E2E Tests
- GitHub Check: Run Unit Tests / Unit Tests
- GitHub Check: SonarQube
- GitHub Check: Validate Docker Build
- GitHub Check: Analyze (javascript)
🔇 Additional comments (9)
packages/config-eslint/package.json (3)
6-8
: Upgrade ESLint Next.js and TypeScript ESLint plugins
The devDependencies for@next/eslint-plugin-next
,@typescript-eslint/eslint-plugin
, and@typescript-eslint/parser
have been bumped to their latest patch versions. These are backward-compatible patch updates and should integrate smoothly.
10-12
: Upgrade ESLint configuration packages
Theeslint-config-next
,eslint-config-prettier
, andeslint-config-turbo
entries have been patched to newer minor versions. These are safe, non-breaking updates that align with the rest of your linting tooling.
16-17
: Upgrade React Refresh and Vitest ESLint plugins
Theeslint-plugin-react-refresh
and@vitest/eslint-plugin
have been bumped to patch releases. No additional config changes appear necessary.apps/web/package.json (1)
140-140
: Verify zod version upgrade consistency
Ensure that bumping"zod"
to3.24.4
is compatible with your existing schemas and that the lockfile reflects this change. Run your full test suite (unit, integration, and type checks) to catch any potential breaking changes.packages/database/package.json (2)
37-37
: Confirmprisma-json-types-generator
upgrade
You’ve updated"prisma-json-types-generator"
from3.2.3
to3.3.1
. Verify that this new version generates the expected types and that your migration and data-migration scripts still function correctly. Run the relevant Prisma scripts and compile steps to ensure nothing breaks.
39-39
: Align zod version with other packages
Upgrading"zod"
to3.24.4
should stay in sync with the versions in other workspaces. Ensure that schema validations and any OpenAPI generation based on Zod still work as intended by executing your validation tests and builds.packages/config-typescript/package.json (1)
10-11
: Ensure TypeScript definitions compatibility
You bumped@types/node
to22.15.12
and@types/react
to19.1.3
. Please run a clean install followed by a full TypeScript build and lint pass to confirm there are no new type errors or mismatches introduced by these updates.packages/surveys/package.json (1)
41-51
: Validate dev dependency bumps
Minor patch upgrades to@calcom/embed-snippet
(1.3.3
),@types/react
(19.1.3
), andisomorphic-dompurify
(2.24.0
) are low risk but verify that survey embedding, sanitization, and any React typings continue to work without regressions. Run your survey-related unit and integration tests.packages/types/package.json (1)
11-14
: Review dependencies section reordering and zod bump
You moved thedependencies
block and upgradedzod
to3.24.4
here. Confirm that the reordering doesn’t affect any build scripts or tooling, and that the newzod
version is compatible by running your type-checking, build, and validation workflows.
|
This pull request includes the removal of the pull request labeler workflow and multiple dependency updates across various packages to ensure compatibility and maintainability. Below is a summary of the most important changes grouped by theme:
Workflow Removal:
.github/workflows/labeler.yml
file, effectively disabling the pull request labeler workflow. This includes the removal of all associated job configurations, permissions, and steps.Dependency Updates:
Core Dependency Updates:
zod
to version3.24.4
across multiple packages (apps/web
,packages/database
,packages/logger
,packages/types
). [1] [2] [3] [4]@types/react
to version19.1.3
inpackages/config-typescript
andpackages/surveys
. [1] [2]Linter and TypeScript Configuration Updates:
packages/config-eslint
, including@next/eslint-plugin-next
,@typescript-eslint/eslint-plugin
,@typescript-eslint/parser
,eslint-config-next
,eslint-config-prettier
,eslint-config-turbo
, andeslint-plugin-react-refresh
.@types/node
to version22.15.12
inpackages/config-typescript
.Miscellaneous Dependency Updates:
@calcom/embed-snippet
to version1.3.3
andisomorphic-dompurify
to version2.24.0
inpackages/surveys
.prisma-json-types-generator
to version3.3.1
inpackages/database
.Summary by CodeRabbit