8000 chore: updated open telemtry package versions by Dhruwang · Pull Request #5672 · formbricks/formbricks · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: updated open telemtry package versions #5672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2025
Merged

chore: updated open telemtry package versions #5672

merged 1 commit into from
May 6, 2025

Conversation

Dhruwang
Copy link
Member
@Dhruwang Dhruwang commented May 6, 2025 •
edited by coderabbitai bot
Loading

What does this PR do?

Fixes #5378

How should this be tested?

test open telemetry setup

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues
  • First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 🙏

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Summary by CodeRabbit

  • Chores
    • Updated several OpenTelemetry dependencies to newer versions.
    • Removed the unused @opentelemetry/api-logs package from dependencies.

@Dhruwang Dhruwang requested a review from gupta-piyush19 May 6, 2025 11:24
@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented May 6, 2025 •
edited
Loading

Thank you for following the naming conventions for pull request titles! 🙏

@coderabbitai coderabbitai
Copy link
Contributor
coderabbitai bot commented May 6, 2025

Walkthrough

The changes update several OpenTelemetry package dependencies in the apps/web/package.json file to their latest versions and remove the @opentelemetry/api-logs dependency. In the apps/web/instrumentation-node.ts file, the code replaces the synchronous detectResourcesSync method with the asynchronous detectResources for resource detection and changes resource instantiation from direct construction to using resourceFromAttributes. No changes were made to exported or public entities.

Assessment against linked issues

Objective Addressed Explanation
Update all OpenTelemetry dependencies in apps/web to the latest version (#5378) ✅
Fix code errors arising from OpenTelemetry dependency updates and ensure compatibility (#5378) ✅

Possibly related PRs

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed May 6, 2025
View reviewed changes
Copy link
Contributor
@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🧹 Nitpick comments (1)
apps/web/package.json (1)

44-50: Consider adding a lock file update

When updating multiple related packages with significant version changes, it's important to ensure the lock file is updated as well to capture the resolved dependency tree.

Make sure to commit the updated package-lock.json or yarn.lock file along with these changes to ensure consistent dependency resolution across environments.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 649f28f and 4b0bcca.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (2)
  • apps/web/instrumentation-node.ts (2 hunks)
  • apps/web/package.json (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (6)
  • GitHub Check: Build Formbricks-web / Build Formbricks-web
  • GitHub Check: Run E2E Tests / Run E2E Tests
  • GitHub Check: Run Unit Tests / Unit Tests
  • GitHub Check: SonarQube
  • GitHub Check: Validate Docker Build
  • GitHub Check: Analyze (javascript)
🔇 Additional comments (1)
apps/web/package.json (1)

44-50:

✅ Verification successful

Verify removal of @opentelemetry/api-logs

The AI summary indicates that @opentelemetry/api-logs was removed from dependencies. Ensure that this package's functionality is now covered by other packages (possibly by the updated @opentelemetry/sdk-logs).

🏁 Script executed:

#!/bin/bash
# Check for any usage of api-logs in the codebase
echo "Searching for imports of @opentelemetry/api-logs:"
rg -l "@opentelemetry/api-logs" --type ts

Length of output: 150

To be thorough, let’s search all file types for any lingering references:

🏁 Script executed:

#!/bin/bash
# Search for any references to @opentelemetry/api-logs in the entire codebase
echo "Searching for references to @opentelemetry/api-logs in codebase:"
rg -n "@opentelemetry/api-logs"

Length of output: 818

Removal of @opentelemetry/api-logs Verified

No imports or code references to @opentelemetry/api-logs were found outside of lockfile entries, so removing it from apps/web/package.json is safe. Its functionality is now provided by the upgraded @opentelemetry/sdk-logs.

@sonarqubecloud SonarQubeCloud
Copy link
sonarqubecloud bot commented May 6, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Dhruwang Dhruwang added this pull request to the merge queue May 6, 2025
Merged via the queue into main with commit 9a7d24e May 6, 2025
20 of 21 checks passed
@Dhruwang Dhruwang deleted the update-open-telemetry-deps branch May 6, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@mattinannt mattinannt mattinannt approved these changes

@gupta-piyush19 gupta-piyush19 Awaiting requested review from gupta-piyush19

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the open telemetry dependencies to the latest version
2 participants
@Dhruwang @mattinannt
0