8000 Improve Swagger and general refactoring by antoinegelloz · Pull Request #210 · formancehq/ledger · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Improve Swagger and general refactoring #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2022
Merged

Improve Swagger and general refactoring #210

merged 1 commit into from
May 27, 2022

Conversation

antoinegelloz
Copy link
Contributor

No description provided.

@antoinegelloz antoinegelloz requested a review from a team as a code owner May 26, 2022 18:51
@antoinegelloz antoinegelloz requested review from louhde and removed request for a team May 26, 2022 18:51
@codecov
Copy link
codecov bot commented May 26, 2022 •
edited
Loading

Codecov Report

Merging #210 (5a9a6dc) into main (22243e2) will decrease coverage by 0.33%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##             main     #210      +/-   ##
==========================================
- Coverage   65.65%   65.31%   -0.34%     
==========================================
  Files          70       70              
  Lines        3581     3546      -35     
==========================================
- Hits         2351     2316      -35     
- Misses        984      989       +5     
+ Partials      246      241       -5
Impacted Files Coverage Δ
pkg/api/controllers/base_controller.go 73.17% <ø> (ø)
pkg/api/controllers/config_controller.go 51.28% <ø> (ø)
pkg/api/controllers/ledger_controller.go 66.66% <ø> (ø)
pkg/api/controllers/script_controller.go 85.71% <0.00%> (ø)
pkg/api/middlewares/ledger_middleware.go 61.11% <ø> (ø)
pkg/core/transaction.go 66.66% <ø> (ø)
pkg/api/controllers/transaction_controller.go 54.63% <37.50%> (+0.47%) ⬆️
pkg/opentelemetry/opentelemetrytraces/storage.go 52.51% <50.00%> (ø)
pkg/storage/storage.go 60.65% <66.66%> (ø)
pkg/api/controllers/account_controller.go 62.50% <75.00%> (-2.09%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13313cc...5a9a6dc. Read the comment docs.

@antoinegelloz antoinegelloz merged commit 2644062 into main May 27, 2022
@antoinegelloz antoinegelloz deleted the improve-swagger-and-refactoring branch May 27, 2022 10:31
flemzord pushed a commit to flemzord/ledger that referenced this pull request Apr 7, 2023
@adamdecaf
docs: fix links on payment connectors page (formancehq#210)
f71de52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfyrag gfyrag gfyrag approved these changes

@louhde louhde Awaiting requested review from louhde louhde was automatically assigned from formancehq/core

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antoinegelloz @gfyrag
0