8000 Fix empty body when using scopes. by gfyrag · Pull Request #214 · formancehq/ledger · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix empty body when using scopes. #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2022
Merged

Fix empty body when using scopes. #214

merged 1 commit into from
Jun 3, 2022

Conversation

gfyrag
Copy link
Contributor
@gfyrag gfyrag commented Jun 3, 2022

No description provided.

@gfyrag gfyrag requested a review from a team as a code owner June 3, 2022 10:49
@gfyrag gfyrag requested review from antoinegelloz and removed request for a team June 3, 2022 10:49
@gfyrag gfyrag force-pushed the fix/200-empty-response branch from aad1bb6 to 3fa1304 Compare June 3, 2022 10:50
@codecov
Copy link
codecov bot commented Jun 3, 2022 •
edited
Loading

Codecov Report

Merging #214 (d9ab492) into main (8d3f442) will increase coverage by 0.25%.
The diff coverage is 82.60%.

@@            Coverage Diff             @@
##             main     #214      +/-   ##
==========================================
+ Coverage   65.54%   65.80%   +0.25%     
==========================================
  Files          70       70              
  Lines        3579     3600      +21     
==========================================
+ Hits         2346     2369      +23     
+ Misses        992      987       -5     
- Partials      241      244       +3
Impacted Files Coverage Δ
pkg/api/internal/testing.go 87.57% <81.81%> (-1.02%) ⬇️
pkg/api/routes/routes.go 96.66% <100.00%> (+10.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e63f34...d9ab492. Read the comment docs.

@gfyrag gfyrag force-pushed the fix/200-empty-response branch from 3fa1304 to d9ab492 Compare June 3, 2022 10:53
@gfyrag gfyrag merged commit 8edba57 into main Jun 3, 2022
@gfyrag gfyrag deleted the fix/200-empty-response branch June 3, 2022 11:41
flemzord added a commit to flemzord/ledger that referenced this pull request Apr 7, 2023
@flemzord
chore(operator): Replace Command to Args (formancehq#214)
de4b1fd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoinegelloz antoinegelloz antoinegelloz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gfyrag @antoinegelloz
0