8000 Minor housekeeping by madig · Pull Request #3815 · fonttools/fonttools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
/ fonttools Public < 8000 /div>

Minor housekeeping #3815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 6, 2025
Merged

Minor housekeeping #3815

merged 9 commits into from
May 6, 2025

Conversation

madig
Copy link
Collaborator
@madig madig commented Apr 29, 2025 •
edited
Loading
  • Fix a warning about license descriptors when building packages
  • Build docs through a tox command for easier management (tox -e docs)
  • Remove Makefile. Was anyone using it? @behdad?
  • Use uv to build packages
  • Declare that black should use Python 3.9 as the minimum version.
  • Remove unused tox commands bdist and pypi. The former is faster done by uv build, the latter was out of date, given that it was referencing .zip files instead of .tar.gz.

A future housekeeping PR could use uv more thoroughly, i.e. through tox-uv, using the caching mechanisms described in https://docs.astral.sh/uv/guides/integration/github/#caching.

Note that while tox will use uv under the hood, you don't have to use it directly. Unless you want to build packages locally, then you can use uv build or any other established build tool like https://pypi.org/project/build/.

@madig madig requested a review from anthrotype April 29, 2025 15:30
@behdad
Copy link
Member
behdad commented Apr 29, 2025

Makefile change LGTM.

anthrotype
anthrotype approved these changes May 6, 2025
View reviewed changes
Copy link
Member
@anthrotype anthrotype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but needs fixing a little merge conflict

@madig madig force-pushed the minor-housekeeping branch from a9ba83e to 6dcf268 Compare May 6, 2025 09:25
@madig madig merged commit cac41db into main May 6, 2025
11 checks passed
@madig madig deleted the minor-housekeeping branch May 6, 2025 09:42
@khaledhosny khaledhosny mentioned this pull request May 6, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthrotype anthrotype anthrotype approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@madig @behdad @anthrotype
0