8000 [varLib.interpolatable] Support discrete axes in .designspace by behdad · Pull Request #3599 · fonttools/fonttools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[varLib.interpolatable] Support discrete axes in .designspace #3599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 16, 2024
Merged

[varLib.interpolatable] Support discrete axes in .designspace #3599

merged 1 commit into from
Aug 16, 2024

Conversation

behdad
Copy link
Member
@behdad behdad commented Aug 3, 2024

Fixes #3597

Hummm. Only manually tested.

@behdad behdad requested a review from anthrotype August 3, 2024 23:35
@behdad behdad mentioned this pull request Aug 3, 2024
Closed
@behdad behdad force-pushed the interpolatable-discrete-axes branch 3 times, most recently from 2716490 to 6485392 Compare August 3, 2024 23:50
@colinmford
Copy link
Contributor
colinmford commented Aug 5, 2024 •
edited
Loading

@behdad looks like it works for me!

A minor issue is that when the error is just for one source (like if a glyph is missing), the source name string gets "joined" together:

Glyph A was not compatible:
  Masters: T, e, s, t, F, a, m, i, l, y, -, S, o, u, r, c, e, _, 1, 0, 0, 0, _, 0:
    Glyph was missing in master TestFamily-Source_1000_0

The issue seems to be here:

fonttools/Lib/fontTools/varLib/interpolatable.py

Lines 947 to 953 in 6485392

if master_idxs != last_master_idxs:
master_names = (
(p["master"])
if "master" in p
else (p["master_1"], p["master_2"])
)
print(f" Masters: %s:" % ", ".join(master_names), file=f)

Doesn't affect performance of the check, though!

Thanks for putting this together!

behdad added a commit that referenced this pull request Aug 5, 2024
@behdad
[varLib.interpolatable]
45bd063 
Fix master name formatting.

#3599 (comment)
@behdad
Copy link
Member Author
behdad commented Aug 5, 2024

A minor issue is that when the error is just for one source (like if a glyph is missing), the source name string gets "joined" together:

Fixed. Thanks!

@behdad behdad force-pushed the interpolatable-discrete-axes branch from 6485392 to e3cd51b Compare August 5, 2024 15:45
@behdad behdad merged commit ead2a18 into main Aug 16, 2024
11 checks passed
@behdad behdad deleted the interpolatable-discrete-axes branch August 16, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthrotype anthrotype Awaiting requested review from anthrotype

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[varLib.interpolatable] Does not correctly handle discrete axes
2 participants
@behdad @colinmford
0